test(e2e): add --no-wait on cleanup for e2e tests #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7644724464
💛 - Coveralls |
tallaxes
approved these changes
Jan 24, 2024
tallaxes
added
area/e2e-test-framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
The e2e resources deleting takes up a ~5 minutes, and ~10-20% of the actual runtime of certain test cases.
The resources being deleted is not something that we really need to have considered as a failure, since really we are trying to test karpenter behavior here, not the other Azure deletion APIs.
This overall I think is a fair, useful improvement, which reduces the time taken by the cleanup step from ~5 min to ~15 seconds.
How was this change tested?
Nothing additional.
Note:
Does this change impact docs?
Release Note