Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/AzureAD/microsoft-authentication-library-for-go from 0.9.0 to 1.0.0 #259

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 21, 2023

Bumps github.com/AzureAD/microsoft-authentication-library-for-go from 0.5.2 to 1.0.0.

Release notes

Sourced from github.com/AzureAD/microsoft-authentication-library-for-go's releases.

MSAL Go 1.0.0

  • Better diagnostics message (#304, #403)
  • Prevent persistent cache data races (#402)
  • Switch to new regional endpoints (#361, #408)

MSAL Go 0.9.0

MSAL Go 0.9.x is expected to be the last feature release before an upcoming 1.0 version. Please install and test this version.

This release contains breaking changes. Please refer to "API changes for GA release" for upgrade guidance.

  • Delete vestigial option function types (#383)
  • Rename public client CreateAuthCodeURL -> AuthCodeURL (#371, #384)
  • Delete deprecated confidential.NewCredFromAssertion (#385)
  • Rename confidential.WithAccessor to WithCache (#386)
  • Review all logs to ensure there is no PII (#28, #382)
  • Upgrade dependencies (#387)
  • Remove unused confidential client UserID (#389)
  • Replace NewCredFromCert with NewCredFromCertChain (#391)
  • Remove unnecessary options structs (#390)
  • Upgrade CI tools (#392)
  • Adding ExportReplace to support the Context object (#378)
  • Add optional metadata for cache.ExportReplace (#395, #381)
  • Confidential client requires authority (#394, #348)

MSAL Go 0.8.1

Bugfix: Fix a regression introduced in 0.8.0 causing unnecessary token request during silent auth with "common" or "organizations" home tenant alias. (#375)

MSAL Go v0.8.0

Enhancements:

  • Add per-request tenant ID option WithTenantID (#296, #343)
  • Add WithLoginHint option for interactive authentication (#271, #354)
  • Adding a WithClientCapabilities option for client constructors and a WithClaims option for token acquisition methods (#263, #355)
  • Adding Domain Hint option to be used to accelerate the user to their federated IdP sign-in page (#363)
  • Add support for disabling instance discovery for AzureStack scenarios (#362)

Bug fixes:

  • AuthParams.WithTenant should copy all AuthorityInfo values (#364)
  • Multitenant silent authentication fixes (#366)

MSAL Go 0.7.0

  • Enhancement: Enable using confidential.Client only for token caching (#302, #344)
  • Enhancement: Upgrade linter (#340)

MSAL Go 0.6.1

  • Bugfix: Prevent panic due to invalid confidential.Credential (#341, #342)

MSAL Go 0.6.0

  • Enable updating client assertions via callback (#292, #319)
  • Support certificate chains in SNI authentication (#267, #326)

... (truncated)

Changelog

Sourced from github.com/AzureAD/microsoft-authentication-library-for-go's changelog.

Microsoft Identity SDK Versioning and Servicing FAQ

We have adopted the semantic versioning flow that is industry standard for OSS projects. It gives the maximum amount of control on what risk you take with what versions. If you know how semantic versioning works with node.js, java, and ruby none of this will be new.

Semantic Versioning and API stability promises

Microsoft Identity libraries are independent open source libraries that are used by partners both internal and external to Microsoft. As with the rest of Microsoft, we have moved to a rapid iteration model where bugs are fixed daily and new versions are produced as required. To communicate these frequent changes to external partners and customers, we use semantic versioning for all our public Microsoft Identity SDK libraries. This follows the practices of other open source libraries on the internet. This allows us to support our downstream partners which will lock on certain versions for stability purposes, as well as providing for the distribution over NuGet, CocoaPods, and Maven.

The semantics are: MAJOR.MINOR.PATCH (example 1.1.5)

We will update our code distributions to use the latest PATCH semantic version number in order to make sure our customers and partners get the latest bug fixes. Downstream partner needs to pull the latest PATCH version. Most partners should try lock on the latest MINOR version number in their builds and accept any updates in the PATCH number.

Examples: Using Cocapods, the following in the podfile will take the latest ADALiOS build that is > 1.1 but not 1.2.

pod 'ADALiOS', '~> 1.1'

Using NuGet, this ensures all 1.1.0 to 1.1.x updates are included when building your code, but not 1.2.

<dependency
id="ADALfordotNet"
version="[1.1,1.2)"
/>
Version Description Example
x.x.x PATCH version number. Incrementing these numbers is for bug fixes and updates but do not introduce new features. This is used for close partners who build on our platform release (ex. Azure AD Fabric, Office, etc.),In addition, Cocoapods, NuGet, and Maven use this number to deliver the latest release to customers.,This will update frequently (sometimes within the same day),There is no new features, and no regressions or API surface changes. Code will continue to work unless affected by a particular code fix. ADAL for iOS 1.0.10,(this was a fix for the Storyboard display that was fixed for a specific Office team)
x.x MINOR version numbers. Incrementing these second numbers are for new feature additions that do not impact existing features or introduce regressions. They are purely additive, but may require testing to ensure nothing is impacted.,All x.x.x bug fixes will also roll up in to this number.,There is no regressions or API surface changes. Code will continue to work unless affected by a particular code fix or needs this new feature. ADAL for iOS 1.1.0,(this added WPJ capability to ADAL, and rolled all the updates from 1.0.0 to 1.0.12)
x MAJOR version numbers. This should be considered a new, supported version of Microsoft Identity SDK and begins the Azure two year support cycle anew. Major new features are introduced and API changes can occur.,This should only be used after a large amount of testing and used only if those features are needed.,We will continue to service MAJOR version numbers with bug fixes up to the two year support cycle. ADAL for iOS 1.0,(our first official release of ADAL)

Serviceability

When we release a new MINOR version, the previous MINOR version is abandoned.

When we release a new MAJOR version, we will continue to apply bug fixes to the existing features in the previous MAJOR version for up to the 2 year support cycle for Azure. Example: We release ADALiOS 2.0 in the future which supports unified Auth for AAD and MSA. Later, we then have a fix in Conditional Access for ADALiOS. Since that feature exists both in ADALiOS 1.1 and ADALiOS 2.0, we will fix both. It will roll up in a PATCH number for each. Customers that are still locked down on ADALiOS 1.1 will receive the benefit of this fix.

Microsoft Identity SDKs and Azure Active Directory

Microsoft Identity SDKs major versions will maintain backwards compatibility with Azure Active Directory web services through the support period. This means that the API surface area defined in a MAJOR version will continue to work for 2 years after release.

We will respond to bugs quickly from our partners and customers submitted through GitHub and through our private alias (tellaad@microsoft.com) for security issues and update the PATCH version number. We will also submit a change summary for each PATCH number. Occasionally, there will be security bugs or breaking bugs from our partners that will require an immediate fix and a publish of an update to all partners and customers. When this occurs, we will do an emergency roll up to a PATCH version number and update all our distribution methods to the latest.

Commits
  • 4d3329f Merge pull request #412 from AzureAD/release-1.0.0
  • 8e66327 separate assignment from return
  • 62816fd Bump version number
  • 6a16f64 Fix tests broken by #403 (#410)
  • 2d23419 Removing r.login.microsoftonline.com (#408)
  • 4c397f8 Prevent persistent cache data races (#402)
  • 8801762 Revert "Change r.login.microsoftonline.com to login.microsoft.com"
  • 5e54e5e Change r.login.microsoftonline.com to login.microsoft.com
  • 565332c Adding some better diagnostics for len(scopes) == 0 (#403)
  • 3f4287d Merge pull request #396 from AzureAD/dev
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 21, 2023
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/AzureAD/microsoft-authentication-library-for-go-1.0.0 branch 2 times, most recently from 5f3086a to 6d7eac4 Compare May 1, 2023 20:08
@codecov-commenter
Copy link

Codecov Report

Merging #259 (6d7eac4) into master (871f995) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   50.18%   50.18%           
=======================================
  Files          15       15           
  Lines        1100     1100           
=======================================
  Hits          552      552           
  Misses        517      517           
  Partials       31       31           

@cirvine-MSFT
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 2, 2023

Sorry, only users with push access can use that command.

@cirvine-MSFT
Copy link
Contributor

@weinong LGTM
I manually made sure that I could merge this PR onto current master without issue (because dependabot hasn't rebased it).
I also ran make test and went through the quickstart scenario. Should be good to merge

@weinong
Copy link
Contributor

weinong commented May 2, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/AzureAD/microsoft-authentication-library-for-go-1.0.0 branch from 6d7eac4 to 3225d0c Compare May 2, 2023 20:42
@weinong weinong changed the title Bump github.com/AzureAD/microsoft-authentication-library-for-go from 0.5.2 to 1.0.0 Bump github.com/AzureAD/microsoft-authentication-library-for-go from 0.9.0 to 1.0.0 May 2, 2023
@weinong
Copy link
Contributor

weinong commented May 2, 2023

closing it and let dependentbot to recreate

@weinong weinong closed this May 2, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 2, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@weinong weinong deleted the dependabot/go_modules/github.com/AzureAD/microsoft-authentication-library-for-go-1.0.0 branch May 2, 2023 21:49
@weinong weinong restored the dependabot/go_modules/github.com/AzureAD/microsoft-authentication-library-for-go-1.0.0 branch May 2, 2023 21:50
@weinong weinong reopened this May 2, 2023
@weinong
Copy link
Contributor

weinong commented May 2, 2023

@dependabot recreate

Bumps [github.com/AzureAD/microsoft-authentication-library-for-go](https://github.com/AzureAD/microsoft-authentication-library-for-go) from 0.5.2 to 1.0.0.
- [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-go/releases)
- [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/dev/RELEASES.md)
- [Commits](AzureAD/microsoft-authentication-library-for-go@v0.5.2...v1.0.0)

---
updated-dependencies:
- dependency-name: github.com/AzureAD/microsoft-authentication-library-for-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/AzureAD/microsoft-authentication-library-for-go-1.0.0 branch from 3225d0c to b8b397c Compare May 2, 2023 21:52
Copy link
Contributor

@cirvine-MSFT cirvine-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cirvine-MSFT cirvine-MSFT merged commit adea446 into master May 3, 2023
6 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/AzureAD/microsoft-authentication-library-for-go-1.0.0 branch May 3, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants