Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github token support #366

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

weinong
Copy link
Contributor

@weinong weinong commented Dec 1, 2023

added github token support via ACTIONS_ID_TOKEN_REQUEST_URL and ACTIONS_ID_TOKEN_REQUEST_TOKEN in workload identity login

it addresses #353

…NS_ID_TOKEN_REQUEST_TOKEN in workload identity login
@weinong
Copy link
Contributor Author

weinong commented Dec 1, 2023

tested in this github actions.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (a7eddd9) 65.16% compared to head (436860f) 64.77%.

Files Patch % Lines
pkg/token/federatedIdentity.go 50.00% 26 Missing and 10 partials ⚠️
pkg/token/interactive.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   65.16%   64.77%   -0.39%     
==========================================
  Files          23       23              
  Lines        1728     1766      +38     
==========================================
+ Hits         1126     1144      +18     
- Misses        539      549      +10     
- Partials       63       73      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/token/federatedIdentity.go Outdated Show resolved Hide resolved
pkg/token/federatedIdentity.go Outdated Show resolved Hide resolved
pkg/token/federatedIdentity.go Outdated Show resolved Hide resolved
pkg/token/federatedIdentity.go Show resolved Hide resolved
Copy link
Member

@bcho bcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit 837674f into Azure:master Dec 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants