[library usage] Move modules under pkg
to pkg/internal
#376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of the changes for #373
In this pull request we moved most of the sub packages under
pkg
topkg/internal
except thepkg/cmd
. Thepkg/cmd
is needed to be exported frompkg
level as Go's internal package rule limit the internal package visibility level topkg
only. We also hid sub-commands frompkg/cmd
to avoid unexpected references.Now, the root level main function imports only
pkg/cmd
and it will be served as the sole entry point. This is slightly off from the design doc, but I believe the usage experience would be better as we allow user to install kubelogin via this: