Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tidy go.mod and bump go version #448

Merged
merged 3 commits into from
Apr 18, 2024
Merged

fix: tidy go.mod and bump go version #448

merged 3 commits into from
Apr 18, 2024

Conversation

bcho
Copy link
Member

@bcho bcho commented Apr 18, 2024

Unit test builds are failing because of the go.mod is unclean:

https://github.com/Azure/kubelogin/actions/runs/8745206780/job/23999744442

This pull request:

  • reran the go mod tidy
  • bumped the go version to 1.21 (the latest go version is 1.22)
  • removed snap build

Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit 98fa9e8 into main Apr 18, 2024
7 checks passed
@bcho bcho deleted the hbc/ut-failure branch April 18, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants