Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get host address from driver socket #399

Merged
merged 6 commits into from
Oct 22, 2018

Conversation

flybywind
Copy link
Contributor

try to fix the problem decribed in issue 397:
#397

@mmlspark-bot
Copy link
Contributor

@msftclas
Copy link

msftclas commented Oct 17, 2018

CLA assistant check
All CLA requirements met.

imatiach-msft
imatiach-msft previously approved these changes Oct 17, 2018
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me try this out once we get a green build

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (3127a57d)

MMLSpark 0.14.dev10+5.g3127a57d

This is a build for Github PR #399, changes:


@flybywind
Copy link
Contributor Author

thanks, and I have tested it on a large dataset in our spark, results seemed well

tools/runme/build.sh Outdated Show resolved Hide resolved
tools/runme/build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (db5c51c6)

MMLSpark 0.14.dev10+6.gdb5c51c6

This is a build for Github PR #399, changes:


@imatiach-msft
Copy link
Contributor

I verified this PR on a spark cluster with the build, @mhamilton723 could you please approve the PR? Thanks!

@mhamilton723 mhamilton723 merged commit bd4f3ca into microsoft:master Oct 22, 2018
@imatiach-msft imatiach-msft mentioned this pull request Oct 24, 2018
@chibberto chibberto mentioned this pull request Oct 25, 2018
@imatiach-msft imatiach-msft mentioned this pull request Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants