Allow password-less proxySettings #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that in some enterprise customer the proxy auth settings include a username, but not a password: microsoft/AzureStorageExplorer#4430 This change allows password-less auth settings to be passed to the underlying agent. It's unclear whether it's a real scenario when a proxy auth has a password, but not username so this PR doesn't consider this scenario.
jeremymeng
force-pushed
the
passwordless-proxysettings
branch
from
9b6d599
to
ce25202
Compare
deyaaeldeen
approved these changes
Jun 15, 2021
ramya-rao-a
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that in some enterprise customer the proxy auth settings include a
username, but not a password: microsoft/AzureStorageExplorer#4430
This change allows password-less auth settings to be passed to the underlying agent.
It's unclear whether it's a real scenario when a proxy auth has a password, but
not username so this PR doesn't consider this scenario.