Ingress Error

.github/workflows/documentation.yml

@@ -28,7 +28,7 @@ concurrency:
 jobs:
   # Spell Check job
   SpellCheck:
-    if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'  # Run on PR and manual dispatch
+    if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -45,7 +45,7 @@ jobs:
   # Deployment job
   Deploy:
     needs: SpellCheck  # Run only after SpellCheck job is successful
-    if: github.event_name == 'push' && github.ref == 'refs/heads/main' || github.event_name == 'workflow_dispatch'
+    if: (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'workflow_dispatch'
     environment:
       name: github-pages
     runs-on: ubuntu-latest

bicep/main.bicep

@@ -421,7 +421,7 @@ module serviceBlade 'modules/blade_service.bicep' = {
     clusterSize: enableBurstable ? 'Burstable' : 'Standard'
     clusterAdminIds: clusterAdminIds
 
-    clusterIngress: ingressType == '' ? 'Both' : ingressType
+    clusterIngress: ingressType == '' ? 'External' : ingressType
     serviceCidr: clusterNetwork.serviceCidr == '' ? '172.16.0.0/16' : clusterNetwork.serviceCidr
     dnsServiceIP: clusterNetwork.dnsServiceIP == '' ? '172.16.0.10' : clusterNetwork.v
     networkPlugin: enablePodSubnet ? 'azure' : clusterNetworkPlugin

charts/istio-ingress/README.md

@@ -8,5 +8,7 @@ Install the helm chart.
 ```bash
 # Create Namespace
 NAMESPACE=istio-system
+helm template istio-ingress -f custom_values.yaml .
+
 helm upgrade --install istio-ingress . -n $NAMESPACE
 ```

charts/istio-ingress/templates/gateways.yaml

@@ -32,30 +32,29 @@ spec:
         {{- else }}
         - "*"
         {{- end }}
-      {{- if .requireSSL }}
       tls:
+        {{- if .requireSSL }}
         httpsRedirect: true # sends 301 redirect for http requests
-      {{- end }}
-      {{- with .tls }}
-      tls:
-        {{- toYaml . | nindent 8 }}
+        {{- end }}
+        {{- with .tls }}
+        {{- toYaml . | nindent 8 }}  
       {{- end }}
 {{- end }}
 
 {{- if .Values.ingress }}
   {{- if hasKey .Values.ingress "internalGateway" }}
     {{- if .Values.ingress.internalGateway.enabled }}
 ---
-{{- $internalGateway := merge (dict "gatewayType" "internal") .Values.ingress.internalGateway -}}
+{{- $internalGateway := merge (dict "gatewayType" "internal" "requireSSL" .Values.ingress.internalGateway.requireSSL) .Values.ingress.internalGateway -}}
 {{ include "gateway" $internalGateway }}
     {{- end }}
   {{- end }}
 
   {{- if hasKey .Values.ingress "externalGateway" }}
     {{- if .Values.ingress.externalGateway.enabled }}
 ---
-{{- $externalGateway := merge (dict "gatewayType" "external") .Values.ingress.externalGateway -}}
+{{- $externalGateway := merge (dict "gatewayType" "external" "requireSSL" .Values.ingress.externalGateway.requireSSL) .Values.ingress.externalGateway -}}
 {{ include "gateway" $externalGateway }}
     {{- end }}
   {{- end }}
-{{- end }}
+{{- end }}

docs/src/feature_flags.md

@@ -52,7 +52,6 @@ Modify the AKS cluster network configuration for Azure CNI with Dynamic IP alloc
 | ENABLE_POD_SUBNET         | Enables a separate subnet for pod networking in the AKS cluster             |
 
 
-
 ## Vnet Injection
 
 __Purpose:__ Enables a bring your own network capability.