Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ksm upgrade to 2.12.0 #887

Merged
merged 4 commits into from
May 24, 2024
Merged

Ksm upgrade to 2.12.0 #887

merged 4 commits into from
May 24, 2024

Conversation

Sohamdg081992
Copy link
Contributor

@Sohamdg081992 Sohamdg081992 commented May 15, 2024

PR Description

Upgrade ksm to 2.12.0
I have upgraded chart using backdoor deployment and found no issues , this is build link : https://github-private.visualstudio.com/azure/_build/results?buildId=80951&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76.

I have compared between old and new KSM chart versions of helm charts for the charts we use(deployment,role,service,etc) and found no major changes between the old and new. Mainly the changes are in the parameterizing some properties based on some properties in values.yaml, but we do not have those properties in our values-template.yaml in our addon chart , so we are good there. Here are the comparison of K-S-M charts.

Screenshots of metrics flowing after upgrade:
ksmupgrade

ksmupgrade1

This change was tested using following mechanism.

The annotations are flowing before and after the upgrade(below screenshot). The metrics are flowing fine and upgrade was successful.

Change:
If the annotation or label has no configured allowed values (--metric-annotations-allowlist, --metric-labels-allowlist) no object_annotations or object_labels metrics should be created.

For our testing, no change was made in either flags (--metric-annotations-allowlist, --metric-labels-allowlist) and upgraded chart was deployed. The default labels and annotations stopped flowing after the upgrade.

Before upgrade:
before

After upgrade:
after

New Feature Checklist

  • List telemetry added about the feature.
  • Link to the one-pager about the feature.
  • List any tasks necessary for release (3P docs, AKS RP chart changes, etc.) after merging the PR.
  • Attach results of scale and perf testing.

Tests Checklist

  • Have end-to-end Ginkgo tests been run on your cluster and passed? To bootstrap your cluster to run the tests, follow these instructions.
    • Labels used when running the tests on your cluster:
      • operator
      • windows
      • arm64
      • arc-extension
      • fips
  • Have new tests been added? For features, have tests been added for this feature? For fixes, is there a test that could have caught this issue and could validate that the fix works?

@Sohamdg081992 Sohamdg081992 requested a review from a team as a code owner May 15, 2024 02:50
@Sohamdg081992 Sohamdg081992 merged commit b959a08 into main May 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants