fix: using dist version of mapbox gl css #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulinscottkang
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Thank you @rvdkooy! I will merge and create a new release for this.
And just for your reference, react-azure-maps@next removed the css imports so that apps will need to import the css manually. Please see MIGRATION.md for more details. Thanks.
|
thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed react-azure-maps was importing the src version of
Mapbox gl.This can be inconvenient because now you have to setup a postcss configuration in your project if you want
Mapbox glto work properlyTailwind with a postcss configuration even fails because of a limitation (nested selectors within a @media query fails, which is used in the src version of
Mapbox gl)this PR will make it much simpler by including the dist version of
Mapbox gl