-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for port auto negotiation feature #3376
Merged
liat-grozovik
merged 5 commits into
sonic-net:master
from
Junchao-Mellanox:test-auto-neg-review
May 30, 2021
Merged
Add test cases for port auto negotiation feature #3376
liat-grozovik
merged 5 commits into
sonic-net:master
from
Junchao-Mellanox:test-auto-neg-review
May 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 1 alert when merging b3f1f1f into 95039c7 - view on LGTM.com new alerts:
|
The test failure is not related to the change. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
jleveque
approved these changes
Apr 28, 2021
jleveque
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM some minor cosmetic changes required
Junchao-Mellanox
requested review from
liat-grozovik
and removed request for
a team
May 25, 2021 11:18
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
May 30, 2021
4 tasks
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
- Summary: Add test cases for port auto negotiation feature - What is the motivation for this PR? Add test cases for port auto negotiation feature - How did you do it? Add test case to verify "config interface advertised-speeds <interface_name> all" Add test case to verify "config interface advertised-speeds <interface_name> " Add test case to verify "config interface speed <interface_name> " - How did you verify/test it? Manually run the test case on Mellanox platform - Any platform specific information? N/A - Supported testbed topology if it's a new test case? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add test cases for port auto negotiation feature
Type of change
Approach
What is the motivation for this PR?
Add test cases for port auto negotiation feature
How did you do it?
How did you verify/test it?
Manually run the test case on Mellanox platform
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation