DHCP relay for IPv6 HLD #765

shlomibitton · 2021-03-26T10:28:02Z

PR title	state	context
[sonic-buildimage] DHCP relay support for IPv6
[dhcp_relay] DHCPv6 relay minigraph parsing support
[dhcp_relay] Enhance DHCP monitor application to support DHCPv6
[sonic-buildimage] make DHCP relay an extension
[sonic-buildimage] Disable dhcp_relay for ToRRouter switches type by the feature manager
[dhcp_relay] Adapt config/show CLI commands to support DHCPv6 relay
[dhcp_relay] Update CLI reference document and add a new API for ip address type
[sonic-mgmt] DHCPv6 automatic test

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

tahmed-dev · 2021-04-12T18:36:48Z

doc/DHCPv6_Relay/DHCPv6_Relay_HLD.md

+
+DHCP Relay for IPv6 feature in SONiC should meet the following high-level functional requirements:
+
+- Give the support for relaying DHCP packets from downstream networks to upstream networks using IPv6 addresses.


One more requirement here is to support RFC:6936 option 79 as part of DHCPv6 relay functionality.

But this is out of the scope of this HLD. this HLD is to cover only existing functionality on top of IPv6.
Any additional requirements should come with a new HLD to cover the new requirements.
@tahmed-dev do you agree?

tahmed-dev · 2021-04-14T00:24:23Z

doc/DHCPv6_Relay/DHCPv6_Relay_HLD.md

+
+## 2.3 DHCP Monitor
+
+The existing DHCP monitor will be enhanced in order to support monitoring for DHCP IPv6 as well.


DHCP counters will be part of the new DHCPv6 relay.

So with the new approach the DHCP monitor application will be removed?

Is there any support for DHCPv6 relay counters ? These will help a lot for debugging.

Yes there is, the DHCP monitor application is now supporting monitor for these counters as well.
Please check the PR of the implementation.

Is there any support for DHCPv6 relay counters ? These will help a lot for debugging.

Yes, there will be native support in the app to pull counters. Please have a look at PR:787

Yes there is, the DHCP monitor application is now supporting monitor for these counters as well.
Please check the PR of the implementation.

the dhcpmon will not exist in DHCPv6 world, rather its functionality will be in the new SONiC DHCPv6 RA.

@tahmed-dev Can you please elaborate why the dhcpmon will not exist?
Same as the IPv4 implementation of this monitor, we can check inconsistency in received and transmitted packets.
for received SOLICIT/REQUEST packets we expect to see a RELAY-FORWARD packet transmitted.
for received RELAY-REPLY packets we expect to see ADVERTISE/REPLY packet transmitted.

@shlomibitton The driving force to have a monitoring application (dhcpmon) was that ISC DHCP does not integrate well with SONIiC infra and its counters were not readily available via telemetry.. With the new DHCPv6 RA, it will integrate with the SONiC redis db and its counters will be available via telemetry and cli. So, we thought about eliminating it.

One might argue that the monitoring app would still capture anomalies in DHCPv6 behavior as it is external to it. I am not sure if this is a design pattern we would like to follow as if we end with every app having a shadow app that monitors it, one can image the number of app would grow...

Also, dhcpmon is launching per interface which is inefficient to have a process for every interface that has dhcp relay enabled.

Please comment on PR:787

@tahmed-dev thanks for the explanation.
On this case, what do you suggest to use as a monitor application with the isc-dhcp-relay package on this case?
This HLD is based on this implementation and we would like to have some kind of a monitor right?
On the other HLD on 'counters' section all I can see is the approach to keep the number of each message type but that's about it.

@shlomibitton counters will be available via telemetry. The cloud would alert on counters if incrementing. Also, we can alternatively add checks similar to dhcpmon monitoring check and print to syslog. I believe Telemetry is maturing now and so the former solution should be adopted.

For this HLD, it is fine to have dhcpmon changes for the time being. This HLD and the accompanying code will be reverted once the new solution is merged.

tahmed-dev · 2021-04-14T00:26:28Z

doc/DHCPv6_Relay/DHCPv6_Relay_HLD.md

+- Downstream network is the VLAN interface with the relay configuration. Global IPv6 address is required to be configured on that interface. 
+- Config DB schema should meet the following format:
+```
+{


This is not finalized yer, however the idea is to have DHCP in a separate feature table instead of being property of Vlan. Something as follows:

"DHCP": { "downlink-intf-i": { "dhcpv4_servers": ["dhcp-server-0", "dhcp-server-1", ...., "dhcp-server-n-1"], "dhcpv6_servers": ["dhcp-server-0", "dhcp-server-1", ...., "dhcp-server-n-1"] } }

Currently it is implemented in a way supervisord on dhcp_relay docker is taking the data by the 'dhcp_servers' on the Vlan interface.
To adapt this new approach all needed is to change the template to this schema.

tahmed-dev · 2021-04-14T00:27:10Z

doc/DHCPv6_Relay/DHCPv6_Relay_HLD.md

+The new process will listen to DHCP packets for IPv6 and forward them to the relevant interface according to the configuration.
+For example, from the configuration described on the previous section, the following daemon will start:
+```
+admin@sonic:/# /usr/sbin/dhcrelay -6 -d --name-alias-map-file /tmp/port-name-alias-map.txt -l Vlan1000 -u 21da:d3:0:2f3b::7%Ethernet28 -u 21da:d3:0:2f3b::6%Ethernet28


The new process will read config data from config db and will not rely on cli.

Yes sure, this instance is taken from config DB data, by the template generated for supervisord on dhcp_realy docker.

Is it mandatory to specify the upstream interface along with the DHCPv6 server address? The server may not be directly connected to the L3 relay - for example, we could have an IPv6 route to the DHCPv6 server. Will that scenario work? What happens if the IPv6 addresses are removed/re-configured to different upstream interface? Will that require restart of DHCP docker?

For the user this configuration is transparent, same as the IPv4 implementation, isc-dhcp-relay will try to relay DHCP packets to all configured servers, the kernel will determine if to send the packet or not depending on the route available in the kernel.
If the server is not directly connected to the L3 interface the DHCP_FORWARD message will be transmitted, if another relay is on the other side, it will forward the message again until it will reach the server and vise versa.
if the IPv6 addresses are removed/re-configured on the L3 up link interfaces than yes, a restart of the service is required.

liat-grozovik · 2021-04-28T08:49:24Z

@tahmed-dev and @lguohan
This HLD was presented in the community as planned and based on it the PRs will be soon available.
Beside of the fact that new DHCP relay for IPv6 will be available later, do you have any feedback to this HLD or we can move forward and approve it?

liat-grozovik · 2021-05-13T12:42:38Z

@tahmed-dev and @lguohan
This HLD was presented in the community as planned and based on it the PRs will be soon available.
Beside of the fact that new DHCP relay for IPv6 will be available later, do you have any feedback to this HLD or we can move forward and approve it?

@tahmed-dev can you please approve?

santoshdoke · 2021-06-17T04:03:11Z

doc/DHCPv6_Relay/DHCPv6_Relay_HLD.md

+The new process will listen to DHCP packets for IPv6 and forward them to the relevant interface according to the configuration.
+For example, from the configuration described on the previous section, the following daemon will start:
+```
+admin@sonic:/# /usr/sbin/dhcrelay -6 -d --name-alias-map-file /tmp/port-name-alias-map.txt -l Vlan1000 -u 21da:d3:0:2f3b::7%Ethernet28 -u 21da:d3:0:2f3b::6%Ethernet28


Is it mandatory to specify the upstream interface along with the DHCPv6 server address? The server may not be directly connected to the L3 relay - for example, we could have an IPv6 route to the DHCPv6 server. Will that scenario work? What happens if the IPv6 addresses are removed/re-configured to different upstream interface? Will that require restart of DHCP docker?

santoshdoke · 2021-06-17T04:04:49Z

doc/DHCPv6_Relay/DHCPv6_Relay_HLD.md

+## 1.2 Configuration and Management Requirements
+
+- DHCPv6 trap should be enabled through the COPP manager when the DHCP relay feature is enabled and vice versa. 
+- Downstream network is the VLAN interface with the relay configuration. Global IPv6 address is required to be configured on that interface. 


Can the downstream interface be a physical L3 interfaces or PortChannel L3 interface (with out VLAN)?

On the scope of this HLD, the downsteam network designed to be a Vlan interface.

santoshdoke · 2021-06-17T04:06:25Z

doc/DHCPv6_Relay/DHCPv6_Relay_HLD.md

+
+## 2.3 DHCP Monitor
+
+The existing DHCP monitor will be enhanced in order to support monitoring for DHCP IPv6 as well.


Is there any support for DHCPv6 relay counters ? These will help a lot for debugging.

tahmed-dev

I think we should close this PR in favor of PR:787

liat-grozovik · 2021-06-27T08:20:31Z

I think we should close this PR in favor of PR:787

I disagree.
This HLD was before any other HLD. this HLD was part of the early stage of 202106 and the provided changes/fixes are aligned with this HLD.
The other HLD was never discussed in the community and can be an enhancement on top of it.
Please proceed with this HLD approval and the code review of all the PRs tracked on this HLD.

tahmed-dev · 2021-06-29T17:20:30Z

I think we should close this PR in favor of PR:787

I disagree.
This HLD was before any other HLD. this HLD was part of the early stage of 202106 and the provided changes/fixes are aligned with this HLD.
The other HLD was never discussed in the community and can be an enhancement on top of it.
Please proceed with this HLD approval and the code review of all the PRs tracked on this HLD.

Thanks @liat-grozovik! Can we agree on the following two points?

We are not going to have two DHCPv6 relay agents in SONiC build-image repository, and
There should not be two HLDs describing the functionality of the same feature/binary.

tahmed-dev

This HLD will serve as bridge gap solution and will be reverted once new HLD and new DHCPv6 relay agent are merged.

Why I did it Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only. This will allow the IPv6 functionality along the IPv4 type. How I did it Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB. Align cfg unit test to the new change. Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT. How to verify it Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765 Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Split docker-dhcp-relay.supervisord.conf.j2 template into several files for easier code maintenance

Why I did it Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only. This will allow the IPv6 functionality along the IPv4 type. How I did it Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB. Align cfg unit test to the new change. Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT. How to verify it Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765 Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Split docker-dhcp-relay.supervisord.conf.j2 template into several files for easier code maintenance (cherry picked from commit 604becd)

DHCP relay for IPv6 HLD

04a14bd

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

tahmed-dev reviewed Apr 14, 2021

View reviewed changes

tahmed-dev requested a review from kellyyeh April 14, 2021 00:28

liat-grozovik approved these changes May 23, 2021

View reviewed changes

shlomibitton mentioned this pull request Jun 1, 2021

[dhcp_relay] DHCP relay support for IPv6 sonic-net/sonic-buildimage#7772

Merged

5 tasks

santoshdoke reviewed Jun 17, 2021

View reviewed changes

santoshdoke approved these changes Jun 24, 2021

View reviewed changes

tahmed-dev suggested changes Jun 24, 2021

View reviewed changes

tahmed-dev approved these changes Jul 1, 2021

View reviewed changes

tahmed-dev merged commit cf61ace into sonic-net:master Jul 1, 2021

shlomibitton deleted the shlomi_dhcpv6 branch July 27, 2021 16:35

kellyyeh mentioned this pull request Sep 29, 2021

[dhcp_relay] DHCP relay support for IPv6 sonic-net/sonic-buildimage#8871

Merged

5 tasks

shlomibitton mentioned this pull request Apr 19, 2022

Fast-reboot Flow Improvements HLD #980

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DHCP relay for IPv6 HLD #765

DHCP relay for IPv6 HLD #765

shlomibitton commented Mar 26, 2021 •

edited

Loading

tahmed-dev Apr 12, 2021

liat-grozovik Apr 28, 2021

tahmed-dev Apr 14, 2021

shlomibitton Apr 25, 2021

santoshdoke Jun 17, 2021

shlomibitton Jun 17, 2021

tahmed-dev Jun 24, 2021

tahmed-dev Jun 24, 2021

shlomibitton Jun 25, 2021 •

edited

Loading

tahmed-dev Jun 30, 2021

shlomibitton Jul 1, 2021

tahmed-dev Jul 1, 2021

tahmed-dev Apr 14, 2021

shlomibitton Apr 25, 2021

tahmed-dev Apr 14, 2021

shlomibitton Apr 25, 2021

santoshdoke Jun 17, 2021

shlomibitton Jun 21, 2021

liat-grozovik commented Apr 28, 2021

liat-grozovik commented May 13, 2021

santoshdoke Jun 17, 2021

santoshdoke Jun 17, 2021

shlomibitton Jun 21, 2021

santoshdoke Jun 17, 2021

tahmed-dev left a comment

liat-grozovik commented Jun 27, 2021

tahmed-dev commented Jun 29, 2021

tahmed-dev left a comment


		DHCP Relay for IPv6 feature in SONiC should meet the following high-level functional requirements:

		- Give the support for relaying DHCP packets from downstream networks to upstream networks using IPv6 addresses.


		## 2.3 DHCP Monitor

		The existing DHCP monitor will be enhanced in order to support monitoring for DHCP IPv6 as well.

DHCP relay for IPv6 HLD #765

DHCP relay for IPv6 HLD #765

Conversation

shlomibitton commented Mar 26, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shlomibitton Jun 25, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liat-grozovik commented Apr 28, 2021

liat-grozovik commented May 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tahmed-dev left a comment

Choose a reason for hiding this comment

liat-grozovik commented Jun 27, 2021

tahmed-dev commented Jun 29, 2021

tahmed-dev left a comment

Choose a reason for hiding this comment

shlomibitton commented Mar 26, 2021 •

edited

Loading

shlomibitton Jun 25, 2021 •

edited

Loading