[dhcp_relay] DHCP relay support for IPv6 #7772

shlomibitton · 2021-06-01T11:27:31Z

Why I did it

Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only.
This will allow the IPv6 functionality along the IPv4 type.

How I did it

Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB.
Align cfg unit test to the new change.
Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT.

How to verify it

Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765
Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

tahmed-dev

Nice work, thanks!

Can we split this PR into 3 as follows:

Changes related to graph parsing
Changes related to ISC DHCPv6 params + required cfggen change to pass the test
Changes related to dhcpmon + ditto for cfggen

src/dhcpmon/src/dhcp_device.c

Edit supervisord template to start DHCPv6 instance Align cfg unit test to new change Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

shlomibitton · 2021-07-04T16:55:51Z

Nice work, thanks!

Can we split this PR into 3 as follows:

Changes related to graph parsing

Changes related to ISC DHCPv6 params + required cfggen change to pass the test

Changes related to dhcpmon + ditto for cfggen

@tahmed-dev I divided this PR into 3:
#7772
#8060
#8125

src/sonic-config-engine/minigraph.py

dockers/docker-dhcp-relay/docker-dhcp-relay.supervisord.conf.j2

Why I did it Allow deploying DHCPv6 servers following the implementation PR: #7772 How I did it Add DHCPv6 to minigraph.py on sonic-cfggen tool and improve the unit test to cover this change. How to verify it Try to deploy a switch with DHCPv6 servers. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

…es for easier code maintenance

shlomibitton · 2021-07-13T06:00:53Z

/azpw run

mssonicbld · 2021-07-13T06:00:54Z

/AzurePipelines run

azure-pipelines · 2021-07-13T06:01:13Z

Azure Pipelines successfully started running 1 pipeline(s).

shlomibitton · 2021-07-13T13:50:26Z

Test failure is not related to this change:
stderr_lines: WARNING: No route found for IPv6 destination

dockers/docker-dhcp-relay/dhcpv4-relay.agents.j2

tahmed-dev

LGTM, just nit related to eol at the end of each new file.

#### Why I did it Enhance DHCP monitor application following the implementation PR: #7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.

Why I did it Allow deploying DHCPv6 servers following the implementation PR: #7772 How I did it Add DHCPv6 to minigraph.py on sonic-cfggen tool and improve the unit test to cover this change. How to verify it Try to deploy a switch with DHCPv6 servers. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

Why I did it Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only. This will allow the IPv6 functionality along the IPv4 type. How I did it Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB. Align cfg unit test to the new change. Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT. How to verify it Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765 Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Split docker-dhcp-relay.supervisord.conf.j2 template into several files for easier code maintenance

Why I did it Allow deploying DHCPv6 servers following the implementation PR: sonic-net#7772 How I did it Add DHCPv6 to minigraph.py on sonic-cfggen tool and improve the unit test to cover this change. How to verify it Try to deploy a switch with DHCPv6 servers. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

Why I did it Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only. This will allow the IPv6 functionality along the IPv4 type. How I did it Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB. Align cfg unit test to the new change. Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT. How to verify it Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765 Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Split docker-dhcp-relay.supervisord.conf.j2 template into several files for easier code maintenance

…c-net#8060) #### Why I did it Enhance DHCP monitor application following the implementation PR: sonic-net#7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.

Why I did it Currently SONiC use the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks only. This will allow the IPv6 functionality along the IPv4 type. How I did it Edit supervisord template to start DHCPv6 instances when configured to do so on Config DB. Align cfg unit test to the new change. Add DHCPv6 relay minigraph parsing support and a suitable t0 topology xml file for UT. How to verify it Configure DHCPv6 agents as described on the feature HLD: sonic-net/SONiC#765 Test it with real client/server with IPv6 or use the dedicated automatic test: sonic-net/sonic-mgmt#3565 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Split docker-dhcp-relay.supervisord.conf.j2 template into several files for easier code maintenance (cherry picked from commit 604becd)

…c-net#8060) #### Why I did it Enhance DHCP monitor application following the implementation PR: sonic-net#7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR. (cherry picked from commit bef5477)

qiluo-msft · 2021-10-15T00:37:55Z

This PR could not be cleanly cherry-pick to 202012. Please submit another PR.

shlomibitton · 2021-10-17T07:41:04Z

This PR could not be cleanly cherry-pick to 202012. Please submit another PR.

@qiluo-msft, kelly already created a new PR for this branch and it is merged, by PR: #8871

#### Why I did it Enhance DHCP monitor application following the implementation PR: sonic-net/sonic-buildimage#7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.

shlomibitton requested a review from lguohan as a code owner June 1, 2021 11:27

shlomibitton changed the title ~~[dhcp_relay] Add DHCP relay support for IPv6~~ [dhcp_relay] DHCP relay support for IPv6 Jun 1, 2021

This was referenced Jun 1, 2021

[dhcp_relay] DHCPv6 automatic test sonic-net/sonic-mgmt#3565

Merged

DHCP relay for IPv6 HLD sonic-net/SONiC#765

Merged

liat-grozovik requested a review from tahmed-dev June 21, 2021 15:56

santoshdoke previously approved these changes Jun 28, 2021

View reviewed changes

tahmed-dev suggested changes Jul 1, 2021

View reviewed changes

src/dhcpmon/src/dhcp_device.c Outdated Show resolved Hide resolved

src/dhcpmon/src/dhcp_device.c Outdated Show resolved Hide resolved

src/dhcpmon/src/dhcp_device.c Outdated Show resolved Hide resolved

Add DHCP relay support for IPv6

433210f

Edit supervisord template to start DHCPv6 instance Align cfg unit test to new change Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

shlomibitton dismissed santoshdoke’s stale review via 433210f July 4, 2021 16:42

This was referenced Jul 4, 2021

[dhcp_relay] DHCPv6 relay minigraph parsing support #8059

Closed

[dhcp_relay] Enhance DHCP monitor application to support DHCPv6 #8060

Merged

shlomibitton requested a review from tahmed-dev July 4, 2021 19:44

tahmed-dev reviewed Jul 7, 2021

View reviewed changes

src/sonic-config-engine/minigraph.py Outdated Show resolved Hide resolved

shlomibitton mentioned this pull request Jul 8, 2021

[dhcp_relay] DHCPv6 relay minigraph parsing support #8125

Merged

5 tasks

wangxin mentioned this pull request Jul 9, 2021

Revert "[dhcp_relay] DHCPv6 automatic test" sonic-net/sonic-mgmt#3755

Merged

tahmed-dev reviewed Jul 9, 2021

View reviewed changes

dockers/docker-dhcp-relay/docker-dhcp-relay.supervisord.conf.j2 Outdated Show resolved Hide resolved

shlomibitton mentioned this pull request Jul 11, 2021

[dhcp_relay] DHCPv6 automatic test sonic-net/sonic-mgmt#3767

Merged

3 tasks

shlomibitton requested a review from tahmed-dev July 12, 2021 15:02

Split docker-dhcp-relay.supervisord.conf.j2 template into several fil…

4682999

…es for easier code maintenance

tahmed-dev reviewed Jul 13, 2021

View reviewed changes

dockers/docker-dhcp-relay/dhcpv4-relay.agents.j2 Outdated Show resolved Hide resolved

tahmed-dev previously approved these changes Jul 13, 2021

View reviewed changes

Add EOL for needed files

4a744df

shlomibitton dismissed tahmed-dev’s stale review via 4a744df July 14, 2021 06:53

shlomibitton requested a review from tahmed-dev July 14, 2021 06:54

shlomibitton deleted the shlomi_dhcpv6_relay branch July 20, 2021 08:50

vdahiya12 mentioned this pull request Jul 26, 2021

Design document for Y-cable API support for multiple vendors sonic-net/SONiC#757

Merged

judyjoseph added the Included in 202106 Branch label Aug 4, 2021

kellyyeh mentioned this pull request Sep 29, 2021

Add DHCPv6 minigraph parsing support #8870

Merged

5 tasks

kellyyeh mentioned this pull request Sep 29, 2021

[dhcp_relay] Enhance DHCP monitor application to support DHCPv6 #8872

Merged

5 tasks

kellyyeh added a commit that referenced this pull request Sep 30, 2021

[dhcp_relay] DHCP relay support for IPv6 (#7772) (#8871)

47ba7a9

kellyyeh mentioned this pull request Oct 1, 2021

[dhcp_relay] DHCP relay support for IPv6 #8871

Merged

5 tasks

kellyyeh mentioned this pull request Oct 13, 2021

[201811] Add DHCPv6 minigraph parsing support #8970

Merged

5 tasks

kellyyeh added the Request for 202012 Branch label Oct 14, 2021

kellyyeh added the Included in 202012 Branch label Oct 15, 2021

kellyyeh mentioned this pull request Oct 15, 2021

[201811] Add DHCPv6 Relay Agent #8988

Merged

5 tasks

qiluo-msft removed Request for 202012 Branch Included in 202012 Branch labels Oct 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dhcp_relay] DHCP relay support for IPv6 #7772

[dhcp_relay] DHCP relay support for IPv6 #7772

shlomibitton commented Jun 1, 2021 •

edited by liat-grozovik

Loading

tahmed-dev left a comment

shlomibitton commented Jul 4, 2021 •

edited

Loading

shlomibitton commented Jul 13, 2021

mssonicbld commented Jul 13, 2021

azure-pipelines bot commented Jul 13, 2021

shlomibitton commented Jul 13, 2021

tahmed-dev left a comment

qiluo-msft commented Oct 15, 2021

shlomibitton commented Oct 17, 2021

[dhcp_relay] DHCP relay support for IPv6 #7772

[dhcp_relay] DHCP relay support for IPv6 #7772

Conversation

shlomibitton commented Jun 1, 2021 • edited by liat-grozovik Loading

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

tahmed-dev left a comment

Choose a reason for hiding this comment

shlomibitton commented Jul 4, 2021 • edited Loading

shlomibitton commented Jul 13, 2021

mssonicbld commented Jul 13, 2021

azure-pipelines bot commented Jul 13, 2021

shlomibitton commented Jul 13, 2021

tahmed-dev left a comment

Choose a reason for hiding this comment

qiluo-msft commented Oct 15, 2021

shlomibitton commented Oct 17, 2021

shlomibitton commented Jun 1, 2021 •

edited by liat-grozovik

Loading

shlomibitton commented Jul 4, 2021 •

edited

Loading