[dhcp_relay] DHCPv6 automatic test #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2021 17:14
Add DHCPv6 PTF test Add infrastructure for generating minigraph xml file with DHCPv6 servers Change-Id: I8ae4feea5d47bf512c84a160757288a5d3376cf5 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Add a condition to check if 'dhcpv6_servers' is defined to avoid an exception Change-Id: I71d6a3144d5c77719dcfa1077ec167b7746ff8ee
wangxin
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Please do not merge this PR until sonic-net/sonic-buildimage#7772 is merged.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
test_dhcp_relay_default is failing since PR sonic-net/sonic-buildimage#7772 is not merged yet. |
|
build image pr has been merged, please retest when the image is built. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lguohan Test passed with built image including the buildimage PR. |
|
@wangxin can we proceed with the merge? |
|
Hi @wangxin - could you please review and approve asap, this is needed in 202106 release |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Aug 4, 2021
bingwang-ms
pushed a commit
to bingwang-ms/sonic-mgmt
that referenced
this pull request
Aug 18, 2021
… dhcpv6 relay test Add ansible group variable "dhcpv6_servers" for the new dhcpv6 relay test PR sonic-net#3767 introduced dhcpv6 relay test script that needs variable "dhcpv6_servers" predefined in ansible group vars visible to DUTs. This PR is to define the "dhcpv6_server" group variable in 'ansible/group_vars/str/str.yml' and 'ansible/group_vars/str2/str2.yml' which are used by our starlab DUTs. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
What is the motivation for this PR? Add DHCPv6 automatic test infrastructure and PTF test. How did you do it? * Enhance the minigraph_facts.py and minigraph_dpg.j2 to support DHCPv6 instances. * Add DHCPv6 servers to lab.yml file. * This will deploy on a DUT DHCPv6 servers on regression run. * Develop a test with 3 test cases: * test_dhcp_relay_default * test_dhcp_relay_after_link_flap * test_dhcp_relay_start_with_uplinks_down * Develop a PTF runner test to simulate the traffic according to the test case from sonic-mgmt. How did you verify/test it? Use testbed-cli.sh to generate and deploy a minigraph with DHCPv6 instances on a switch. Run the test. This test depends on PR: [dhcp_relay] DHCP relay support for IPv6 sonic-buildimage#7772 Supported testbed topology if it's a new test case? T0 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
DHCPv6 infrastructure and automatic test.
Type of change
Approach
What is the motivation for this PR?
Add DHCPv6 automatic test infrastructure and PTF test.
How did you do it?
Enhance the minigraph_facts.py and minigraph_dpg.j2 to support DHCPv6 instances.
Add DHCPv6 servers to lab.yml file.
This will deploy on a DUT DHCPv6 servers on regression run.
Develop a test with 3 test cases:
Develop a PTF runner test to simulate the traffic according to the test case from sonic-mgmt.
How did you verify/test it?
Supported testbed topology if it's a new test case?
T0