Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCU loopback interface test #4814

Merged
merged 7 commits into from
Dec 22, 2021
Merged

GCU loopback interface test #4814

merged 7 commits into from
Dec 22, 2021

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Dec 6, 2021

Description of PR

Summary: Testcase of loopback interface for generic updater apply-patch
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on loopback interface

How did you do it?

First we setup clean loopback interface env. Then make some config apply change. And check if the loopback interface is changed as expected.

How did you verify/test it?

Run test of sonic-mgmt/tests/generic_config_updater/test_lo_interface.py on KVM

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wen587 wen587 requested a review from a team as a code owner December 6, 2021 08:42
qiluo-msft
qiluo-msft previously approved these changes Dec 15, 2021
@qiluo-msft
Copy link
Contributor

qiluo-msft commented Dec 20, 2021

service_reset_failed = duthost.shell("sudo systemctl reset-failed {}.service".format(service_name))

As other shell command, seem sudo is implicit. Could you remove?


In reply to: 997668910


Refers to: tests/generic_config_updater/gu_utils.py:126 in 19dd653. [](commit_id = 19dd653, deletion_comment = False)

@qiluo-msft
Copy link
Contributor

qiluo-msft commented Dec 20, 2021

service_start = duthost.shell("sudo systemctl start {}.service".format(service_name))

Remove sudo?


In reply to: 997668984


Refers to: tests/generic_config_updater/gu_utils.py:132 in 19dd653. [](commit_id = 19dd653, deletion_comment = False)

qiluo-msft
qiluo-msft previously approved these changes Dec 20, 2021
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also check with other reviewers.

@wen587 wen587 merged commit ffc5086 into sonic-net:master Dec 22, 2021
AntonHryshchuk pushed a commit to AntonHryshchuk/sonic-mgmt that referenced this pull request Jan 4, 2022
…generic config updater (sonic-net#4814)

Summary:
Testcase of loopback interface for generic updater apply-patch.
Add checkpoint and rollback in gu_utils.

What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on loopback interface

How did you do it?
Make changes to loopback interface thru 'config apply-patch'. Then check if the loopback interface is changed as expected.

How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_lo_interface.py on KVM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants