Added support for port prefix regex #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on sonic-net/sonic-swss-common#598 so it will not pass until it merged |
|
@itamar-talmon unit tests are failing |
This was referenced May 27, 2022
qiluo-msft
reviewed
May 30, 2022
itamar-talmon
force-pushed
the
front_panel_port_name_regex
branch
from
82ebbf2 to
a984fe1
Compare
|
@kcudnik @qiluo-msft - could you please check it out after my update? |
kcudnik
previously approved these changes
Jun 20, 2022
qiluo-msft
previously approved these changes
Jun 20, 2022
|
Quoting @lguohan here:- the overall motivation is not quite clear. can you describe what are you trying to achieve here? here is the sonic port naming convention. for new port names convention to be introduced, we need to make a proposal first here. https://github.com/sonic-net/SONiC/blob/master/doc/sonic-port-name.md |
itamar-talmon
dismissed stale reviews from qiluo-msft and kcudnik
via
78f9dbe
itamar-talmon
force-pushed
the
front_panel_port_name_regex
branch
from
a984fe1 to
78f9dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed the dependency on the "Ethernet" string in the SONiC code base and added support
for extending the front panel port name pattern.
How I did it
Introduced FRONT_PANEL_PORT_PREFIX_REGEX that extends the old FRONT_PANEL_PORT_PREFIX ("Ethernet")
Updated all the relevant usage of the "Ethernet" throughout the code base to use the new regex pattern
How to verify it
Pass all UT and CI testing.
Why I did it
In order to support distinguishing between different types of front panel ports in a maintainable fashion.
Specifically, we are planning to bring up a system with 'service' ports (in addition to the regular ethernet data ports) - these
are lower speed ports that used for connection to accelerators, internal loopbacks and more.
- Related Commits and Merge Strategy
This is part of a group of related commits and should be merged after sonic-net/sonic-swss-common#598 and sonic-net/sonic-buildimage#10471 and sonic-net/sonic-py-swsssdk#121.
The full merge order is:
https://github.com/Azure/sonic-utilities/pull/2127
https://github.com/Azure/sonic-snmpagent/pull/251
https://github.com/Azure/sonic-swss/pull/2223
https://github.com/Azure/sonic-platform-daemons/pull/252
https://github.com/Azure/sonic-platform-common/pull/274