The pclose() function returns -1 if error is detected for executing s… #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hell commands The pclose () function will return the termination state of the shell, which is the end state of the subroutine If an error occurs, pclose() function returns -1, and the cause of the error is stored in errno Signed-off-by: Irene Pan <irene_pan@edge-core.com>
qiluo-msft
reviewed
May 24, 2020
| @@ -34,7 +34,7 @@ int exec(const string &cmd, string &stdout) | |||
| } | |||
|
|
|||
| int ret = pclose(pipe); | |||
| if (ret != 0) | |||
| if (ret == -1) | |||
There was a problem hiding this comment.
if (ret == -1) [](start = 4, length = 14)
Thanks for the fix!
Could you please add some unit test cases to cover:
- return positive value
- return -1 and see the strerror
- return other negative value
BTW, what is the behavior if pclose's wait successfully but cmd returns -1? Can we detect this case and not treat it as ERROR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pclose () function will return the termination state of the shell, which is the end state of the subroutine.
If an error occurs, pclose() function returns -1, and the cause of the error is stored in errno.
Signed-off-by: Irene Pan irene_pan@edge-core.com