Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pclose() function returns -1 if error is detected for executing s… #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

The pclose() function returns -1 if error is detected for executing s… #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/exec.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ int exec(const string &cmd, string &stdout)
}

int ret = pclose(pipe);
if (ret != 0)
if (ret == -1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ret == -1) [](start = 4, length = 14)

Thanks for the fix!
Could you please add some unit test cases to cover:

  1. return positive value
  2. return -1 and see the strerror
  3. return other negative value

BTW, what is the behavior if pclose's wait successfully but cmd returns -1? Can we detect this case and not treat it as ERROR?

{
SWSS_LOG_ERROR("%s: %s", cmd.c_str(), strerror(errno));
}
Expand Down