Improve decorator to support profile config. #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on 3 other PRs merge first to pass build validation:
|
…gin' into dev/liuh/add-decorator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
changed the title
qiluo-msft
reviewed
Jun 20, 2023
| std::shared_ptr<DefaultValueProvider> m_defaultValueProvider; | ||
|
|
||
| /* Handle SubscriberStateTable unknown pattern */ | ||
| void onPopUnknownPattern(RedisMessage& message, std::deque<KeyOpFieldsValuesTuple> &vkco) override; |
qiluo-msft
reviewed
Jun 20, 2023
| @@ -26,6 +26,31 @@ class DecoratorTable : public Table | |||
| /* Get an entry field-value from the table */ | |||
| bool hget(const std::string &key, const std::string &field, std::string &value) override; | |||
|
|
|||
| /* Get all the keys from the table */ | |||
| void getKeys(std::vector<std::string> &keys) override; | |||
qiluo-msft
reviewed
Jun 20, 2023
| const std::string &op = "", | ||
| const std::string &prefix = EMPTY_PREFIX) override; | ||
|
|
||
| /* Unhide override 'set' methods in base class */ |
qiluo-msft
reviewed
Jun 20, 2023
| @@ -25,6 +25,9 @@ class SubscriberStateTable : public ConsumerTableBase | |||
| return !m_buffer.empty(); | |||
| } | |||
|
|
|||
| protected: | |||
| virtual void onPopUnknownPattern(RedisMessage& message, std::deque<KeyOpFieldsValuesTuple> &vkco); | |||
qiluo-msft
reviewed
Jun 20, 2023
| @@ -245,7 +245,30 @@ class ConfigDBConnector_Native : public SonicV2Connector_Native | |||
| def __init__(self, config_db_connector): | |||
| self.connector = config_db_connector | |||
| self.default_value_provider = DefaultValueProvider() | |||
| # helper methods for append default values to result. | |||
| # helper methods for append profile and default values to result. | |||
| def _append_profile(self, result): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Support sonic-swss-common read profile config.
How I did it
Improve decorator to support profile config.
How to verify it
Add new UT to cover new decorate code.
Pass all UT and E2E test cases.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Improve decorator to support profile config.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)