Add ProfileProvider class to support read profile config from PROFILE_DB. #683

liuh-80 · 2022-09-09T04:21:55Z

Why I did it

Add default value and profile support to swss-swss-common.

How I did it

Add ProfileProvider class to support read profile config from PROFILE_DB.

How to verify it

Add new UT.
Pass all existing UT and E2E test.

Which release branch to backport (provide reason below if selected)

Description for the changelog

Add ProfileProvider class to support read profile config from PROFILE_DB.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

liuh-80 · 2022-09-09T06:38:12Z

This PR depends on another PR to pass UT: #681
The reason is UT need modify redis config to create a new UT, which is part of azure pipeline change.

…e-provider

.azure-pipelines/build-sairedis-template.yml

common/dbconnector.cpp

tests/redis_multi_db_ut_config/database_config0.json

qiluo-msft · 2022-09-28T07:15:12Z

    "LOGLEVEL_DB" : {

There is a ongoing PR to remove this DB. Possible to use it?

In reply to: 1260486336

Refers to: tests/redis_multi_db_ut_config/database_config1.json:25 in 9b60524. [](commit_id = 9b60524, deletion_comment = False)

.azure-pipelines/build-template.yml

liuh-80 · 2022-09-28T07:40:53Z

    "LOGLEVEL_DB" : {
There is a ongoing PR to remove this DB. Possible to use it?

Refers to: tests/redis_multi_db_ut_config/database_config1.json:25 in 9b60524. [](commit_id = 9b60524, deletion_comment = False)

I check the loglevel PR, seems that PR only move logger table from LOGLEVEL_DB, seems still something left in that DB.
So, before LOGLEVEL_DB been complete clean-up in database_config.json and schema.h and table.cpp, we can't use ID for that DB.

liuh-80 · 2022-09-28T08:46:49Z

common/configdb.cpp

@@ -244,24 +244,7 @@ void ConfigDBConnector_Native::mod_config(const map<string, map<string, map<stri
 map<string, map<string, map<string, string>>> ConfigDBConnector_Native::get_config()
 {


File change in configdb.cpp dbconnector.cpp and dbconnector.h are from another PR:
#692

liuh-80 · 2022-09-29T00:59:52Z

/azp run

azure-pipelines · 2022-09-29T01:00:05Z

Azure Pipelines successfully started running 1 pipeline(s).

common/database_config.json

liuh-80 · 2022-10-10T07:35:17Z

Will merge after this validation pass: sonic-net/sonic-buildimage#10575

liuh-80 · 2022-10-11T01:31:27Z

Will merge this PR after the validation PR passed: sonic-net/sonic-buildimage#10575

qiluo-msft · 2023-02-18T01:26:42Z

Could you check build failures?

liuh-80 · 2023-02-20T01:48:03Z

Could you check build failures?
The build failure caused by code change in sairedis, following PR will fix it:
#747

liuh-80 · 2023-02-20T03:17:57Z

/azp run

azure-pipelines · 2023-02-20T03:18:08Z

Azure Pipelines successfully started running 1 pipeline(s).

Update sonic-swss-common submodule pointer to include the following: * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>

Update sonic-swss-common submodule pointer to include the following: * 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) Signed-off-by: dprital <drorp@nvidia.com>

Update sonic-swss-common submodule pointer to include the following: * 565ad4b Fix common path issue ([#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([#700](sonic-net/sonic-swss-common#700)) Signed-off-by: dprital <drorp@nvidia.com>

Update sonic-swss-common submodule pointer to include the following: * 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) This is a reland of sonic-net#13950, with the debug image build fix. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Update sonic-swss-common submodule pointer to include the following: * 06ffb51 Define ACL_TABLE and ACL_RULE table in STATE_DB ([sonic-net#748](sonic-net/sonic-swss-common#748)) * 1b369ab [ci] Fix apt-get install unable locate package issue. ([sonic-net#753](sonic-net/sonic-swss-common#753)) * 619d4ec Improve unit test for go wrapper ([sonic-net#752](sonic-net/sonic-swss-common#752)) * 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>

Update sonic-swss-common submodule pointer to include the following: * 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) Signed-off-by: dprital <drorp@nvidia.com>

liuh-80 added 2 commits September 9, 2022 02:36

Install libyang in azure pipeline

ed04b93

Add profile config provider.

3d76913

liuh-80 changed the title ~~Add profile config provider.~~ Add ProfileProvider class to support read profile config from PROFILE_DB. Sep 9, 2022

This was referenced Sep 9, 2022

[HLD] SONiC ConfigDB support Yang default values and profiles. sonic-net/SONiC#989

Open

Improve decorator to support profile config. #684

Open

liuh-80 added 3 commits September 9, 2022 05:03

Fix missing file

364f353

Fix file mode

269b00e

Fix build issue

44c9a75

liuh-80 marked this pull request as ready for review September 9, 2022 06:38

liuh-80 requested a review from qiluo-msft September 9, 2022 06:38

liuh-80 added 3 commits September 9, 2022 07:50

Fix config issue

61db251

Remove add new DB from redis config

4c3c951

Merge branch 'dev/liuh/install-yang-to-pipeline' into dev/liuh/profil…

6dcbee5

…e-provider

liuh-80 mentioned this pull request Sep 13, 2022

Modify azure pipeline to install libyang in azure pipeline steps. #681

Merged

6 tasks

Add new database for UT

4a12abf

liuh-80 commented Sep 13, 2022

View reviewed changes

.azure-pipelines/build-sairedis-template.yml Outdated Show resolved Hide resolved

liuh-80 added 2 commits September 13, 2022 02:11

Fix empty file issue

92acd07

Merge remote-tracking branch 'origin' into dev/liuh/profile-provider

9b60524

qiluo-msft reviewed Sep 28, 2022

View reviewed changes

common/dbconnector.cpp Outdated Show resolved Hide resolved

qiluo-msft reviewed Sep 28, 2022

View reviewed changes

tests/redis_multi_db_ut_config/database_config0.json Outdated Show resolved Hide resolved

qiluo-msft reviewed Sep 28, 2022

View reviewed changes

.azure-pipelines/build-template.yml Outdated Show resolved Hide resolved

Improve UT config file

57b9f59

liuh-80 added 5 commits September 28, 2022 08:04

Fix build issue

02af224

Improve UT

c558e6b

Refactor getall method

9b0653d

Merge branch 'dev/liuh/refact-getall' into dev/liuh/profile-provider

508ed04

Remove unecessary change

35b6774

liuh-80 commented Sep 28, 2022

View reviewed changes

liuh-80 commented Sep 29, 2022

View reviewed changes

common/database_config.json Outdated Show resolved Hide resolved

liuh-80 added 4 commits September 29, 2022 02:17

revert db config change.

a2094ce

Fix DB seperator issue

eef426a

Merge remote-tracking branch 'origin' into dev/liuh/profile-provider

4375c0a

Fix mode issue

c2a377e

qiluo-msft previously approved these changes Oct 10, 2022

View reviewed changes

Merge remote-tracking branch 'origin' into dev/liuh/profile-provider

448a0c4

liuh-80 dismissed qiluo-msft’s stale review via 448a0c4 February 15, 2023 05:56

qiluo-msft approved these changes Feb 21, 2023

View reviewed changes

liuh-80 merged commit 43cadec into sonic-net:master Feb 21, 2023

dprital mentioned this pull request Feb 23, 2023

[submodule] Advance sonic-swss-common pointer sonic-net/sonic-buildimage#13950

Merged

8 tasks

saiarcot895 mentioned this pull request Mar 7, 2023

[submodule] Advance sonic-swss-common pointer sonic-net/sonic-buildimage#14142

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ProfileProvider class to support read profile config from PROFILE_DB. #683

Add ProfileProvider class to support read profile config from PROFILE_DB. #683

liuh-80 commented Sep 9, 2022

liuh-80 commented Sep 9, 2022

qiluo-msft commented Sep 28, 2022 •

edited

Loading

liuh-80 commented Sep 28, 2022 •

edited

Loading

liuh-80 Sep 28, 2022

liuh-80 commented Sep 29, 2022

azure-pipelines bot commented Sep 29, 2022

liuh-80 commented Oct 10, 2022

liuh-80 commented Oct 11, 2022

qiluo-msft commented Feb 18, 2023

liuh-80 commented Feb 20, 2023

liuh-80 commented Feb 20, 2023

azure-pipelines bot commented Feb 20, 2023

		@@ -244,24 +244,7 @@ void ConfigDBConnector_Native::mod_config(const map<string, map<string, map<stri
		map<string, map<string, map<string, string>>> ConfigDBConnector_Native::get_config()
		{

Add ProfileProvider class to support read profile config from PROFILE_DB. #683

Add ProfileProvider class to support read profile config from PROFILE_DB. #683

Conversation

liuh-80 commented Sep 9, 2022

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

liuh-80 commented Sep 9, 2022

qiluo-msft commented Sep 28, 2022 • edited Loading

liuh-80 commented Sep 28, 2022 • edited Loading

liuh-80 Sep 28, 2022

Choose a reason for hiding this comment

liuh-80 commented Sep 29, 2022

azure-pipelines bot commented Sep 29, 2022

liuh-80 commented Oct 10, 2022

liuh-80 commented Oct 11, 2022

qiluo-msft commented Feb 18, 2023

liuh-80 commented Feb 20, 2023

liuh-80 commented Feb 20, 2023

azure-pipelines bot commented Feb 20, 2023

qiluo-msft commented Sep 28, 2022 •

edited

Loading

liuh-80 commented Sep 28, 2022 •

edited

Loading