Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[submodule] Advance sonic-swss-common pointer #13950

Conversation

dprital
Copy link
Collaborator

@dprital dprital commented Feb 23, 2023

Why I did it

Update sonic-swss-common submodule pointer to include the following:

  • 565ad4b Fix common path issue (#751)
  • 3352881 Prevent sonic-db-cli generate core dump (#749)
  • 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. (#683)
  • 8b09f90 Update path to sairedis tests (#747)
  • 85f3776 Non recursive automake and Debian packaging changes (#700)

How I did it

Advance sonic-swss-common pointer

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Update sonic-swss-common submodule pointer to include the following:
* 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751))
* 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749))
* 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683))
* 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747))
* 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700))

Signed-off-by: dprital <drorp@nvidia.com>
@dprital
Copy link
Collaborator Author

dprital commented Feb 23, 2023

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Collaborator Author

dprital commented Feb 23, 2023

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@prsunny please approve so we can merge

@lguohan lguohan merged commit 94cfe83 into sonic-net:master Feb 27, 2023
liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Mar 1, 2023
@liushilongbuaa
Copy link
Contributor

libswsscommon-dbg_1.0.0_amd64.deb package is not built.
Need to revert this PR.

@liat-grozovik
Copy link
Collaborator

how should it be built? is it an automatic flow? and how the checkers pass in sonic-buildimage?

@liushilongbuaa
Copy link
Contributor

command 'dpkg-buildpackage' need to generate libswsscommon-dbg_1.0.0_amd64.deb file.

@liushilongbuaa
Copy link
Contributor

liushilongbuaa commented Mar 1, 2023

PR checks didn't build debug image. So it passed.

xumia pushed a commit that referenced this pull request Mar 2, 2023
Reverts #13950
libswsscommon-dbg_1.0.0_amd64.deb package is not built in new submodule HEAD.
PR validation passed because it didn't build debug image.

13950 breaks debug image build.
saiarcot895 added a commit to saiarcot895/sonic-buildimage that referenced this pull request Mar 7, 2023
Update sonic-swss-common submodule pointer to include the following:
* 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751))
* 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749))
* 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683))
* 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747))
* 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700))

This is a reland of sonic-net#13950, with the debug image build fix.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@dprital dprital deleted the sonic_master_95ce31971_update_sonic-swss-common branch March 7, 2023 19:34
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 10, 2023
Update sonic-swss-common submodule pointer to include the following:
* 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751))
* 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749))
* 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683))
* 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747))
* 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700))

Signed-off-by: dprital <drorp@nvidia.com>
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 10, 2023
…" (sonic-net#14034)

Reverts sonic-net#13950
libswsscommon-dbg_1.0.0_amd64.deb package is not built in new submodule HEAD.
PR validation passed because it didn't build debug image.

13950 breaks debug image build.
liat-grozovik pushed a commit that referenced this pull request Mar 12, 2023
Update sonic-swss-common submodule pointer to include the following:

565ad4b Fix common path issue (#751)
3352881 Prevent sonic-db-cli generate core dump (#749)
43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. (#683)
8b09f90 Update path to sairedis tests (#747)
85f3776 Non recursive automake and Debian packaging changes (#700)
This is a reland of #13950, with the debug image build fix.
vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Mar 18, 2024
…c-net#193)

[cherry-pick] [submodule] Advance sonic-swss-common pointer (sonic-net#14142)
Update sonic-swss-common submodule pointer to include the following:

565ad4b Fix common path issue (sonic-net#751)
3352881 Prevent sonic-db-cli generate core dump (sonic-net#749) 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. (sonic-net#683) 8b09f90 Update path to sairedis tests (sonic-net#747)
85f3776 Non recursive automake and Debian packaging changes (sonic-net#700) This is a reland of sonic-net#13950, with the debug image build fix.

<!--
     Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

     ** Make sure all your commits include a signature generated with `git commit -s` **

     If this is a bug fix, make sure your description includes "fixes #xxxx", or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it

#### How I did it

#### How to verify it

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

#### Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants