Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[submodule] Advance sonic-swss-common pointer" #14034

Conversation

liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Mar 1, 2023

Reverts #13950
libswsscommon-dbg_1.0.0_amd64.deb package is not built in new submodule HEAD.
PR validation passed because it didn't build debug image.

13950 breaks debug image build.

@liushilongbuaa liushilongbuaa marked this pull request as ready for review March 1, 2023 09:54
@liushilongbuaa liushilongbuaa requested a review from lguohan as a code owner March 1, 2023 09:54
@liat-grozovik
Copy link
Collaborator

the main problem is that with this revert we are missing a lot of changes coming from swss-common which are needed just because debug image is not available.
@lguohan is this the right approach?
what is the offended commit that cause it? maybe that one can be reverted on swss-common so we can have the rest in master?

@xumia xumia merged commit b509773 into sonic-net:master Mar 2, 2023
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 10, 2023
…" (sonic-net#14034)

Reverts sonic-net#13950
libswsscommon-dbg_1.0.0_amd64.deb package is not built in new submodule HEAD.
PR validation passed because it didn't build debug image.

13950 breaks debug image build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants