-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202305][SRv6]: SRv6 VPN Unit Tests #2766
Conversation
Reviewed in Routing WG weekly meeting 06082023: |
self.cdb = dvs.get_config_db() | ||
|
||
def create_srv6_vpn_route(self, routeip, nexthop, segsrc, vpn_sid, ifname): | ||
table = "ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shuaishang Since we have FRR support, can we add SRV6 routes and MYSID entries using vtysh commands and validate APPDB and ASICDB? This will validate fpmsyncd code as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For SRv6 VPN feature, it need FRR BGPd to learn routes as SRv6 route which need two DUTs at least in topology. There is no vtysh command to configure static SRv6 route.
So we have to use APP_DB in swss UT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shuaishang is it possible to validate fpmsyncd to APP_DB path by linux route commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SRv6 VPN route didn't install on Linux since the Linux doesn't support it yet... In our case, Zebra will filter out such kind of routes.
It's the same issue to test it on sonic-vs because Linux data plane can't forward SRv6 VPN route.
What I did
Add the swss unit tests for SRv6 VPN functions.
This is the follow-up PR of sonic-swss #2765
It can be merged only after #2765.
Why I did it
How I verified it
pytest test_srv6.py
Details if related