-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weighted ecmp HLD #738
base: master
Are you sure you want to change the base?
Weighted ecmp HLD #738
Conversation
|
||
#### Unit Test cases | ||
|
||
#### System Test cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please describe system test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add:
set up ECMP route with weight through config_db static_route table(e.g. two routes in NHG with weight of 2,8).
Send traffic with enough tuple variations and observe traffic load unevenly distributed on the two routes in the NHG as (20% and 80%).
* @flags CREATE_AND_SET | ||
* @default 1 | ||
*/ | ||
SAI_NEXT_HOP_GROUP_MEMBER_ATTR_WEIGHT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the sai does not support this attribute, what would be the system behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When vendor's SAI don't support, it will be ECMP vs WECMP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check when SAI is supported and handling it accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as comments
8498931
to
8837dc2
Compare
sonic-net/sonic-swss#1752 code PR. |
@caizhenghui-juniper can you please help to sign the EasyCLA? Thanks. |
@zhangyanzhao code PR is merged. Any reason not to merge HLD? |
No description provided.