[nhg]: Add support for weight in nexthop group member. #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In fpmsyncd, parse weight field in nlmsg, set APP_DB if weight is set. 2. In routeorch, collect weight and pass weight attribute to next hop group memeber object.
Change if_weight in routesync.cpp to avoid confusion Signed-off-by: Zhenghui Cai <zcai@juniper.net>
prsunny
approved these changes
May 26, 2021
shi-su
approved these changes
May 26, 2021
vaibhavhd
added a commit
to vaibhavhd/sonic-swss
that referenced
this pull request
Jun 23, 2021
…-net#1752)" This reverts commit a44e651.
lguohan
pushed a commit
that referenced
this pull request
Jun 23, 2021
…" (#1798) This reverts commit a44e651. Proper weight initialization is needed when weights are not provided: https://github.com/Azure/sonic-swss/blob/a44e6513556cfed7de1b70690db90cc09fcef666/orchagent/routeorch.cpp#L638 Warmboot is failing on various platforms: sonic-net/sonic-buildimage#7919 The original PR needs some negative unit testcases when the weight is not present for the nexthop group.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* Add support for weight in nexthop group member. 1. In fpmsyncd, parse weight field in nlmsg, set APP_DB if weight is set. 2. In routeorch, collect weight and pass weight attribute to next hop group memeber object. Signed-off-by: Zhenghui Cai <zcai@juniper.net>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…-net#1752)" (sonic-net#1798) This reverts commit a44e651. Proper weight initialization is needed when weights are not provided: https://github.com/Azure/sonic-swss/blob/a44e6513556cfed7de1b70690db90cc09fcef666/orchagent/routeorch.cpp#L638 Warmboot is failing on various platforms: sonic-net/sonic-buildimage#7919 The original PR needs some negative unit testcases when the weight is not present for the nexthop group.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did Recent change was done to remove call to load database global_db which expects the clients to load global_db. [sonic-net/sonic-buildimage#8173] The load global_db was missing in multi_asic.py which was causing "show interfaces cli" to fail. While testing on multi-asic VS image: How I did it load global_db config in multi_asic.py. How to verify it Load multi-asic VS image with the fix. Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
In order to set weight for next hop group members. To support weighted ECMP.
How I verified it
Details if related