-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Built-in rule] Add SystemAssigned, UserAssigned
as an allowed identity on TA-000007, TA-000013, TA-000019
#370
Merged
reynoldsa
merged 5 commits into
Azure:main
from
richardsondev:jorichar/SystemAssignedUserAssignedRule
Sep 9, 2024
Merged
[Built-in rule] Add SystemAssigned, UserAssigned
as an allowed identity on TA-000007, TA-000013, TA-000019
#370
reynoldsa
merged 5 commits into
Azure:main
from
richardsondev:jorichar/SystemAssignedUserAssignedRule
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraBE
reviewed
Aug 15, 2024
reynoldsa
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
JohnathonMohr
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Just a couple comments.
richardsondev
commented
Sep 5, 2024
richardsondev
changed the title
[Built-in rule] Add
[Built-in rule] Add Sep 5, 2024
SystemAssigned, UserAssigned
as an allowed identity on TA-000013SystemAssigned, UserAssigned
as an allowed identity on TA-000007, TA-000013, TA-000019
JohnathonMohr
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
SystemAssigned, UserAssigned
as an accepted identity on rules TA-000007, TA-000013, TA-000019. This is a valid operation on Azure Functions and currently our bicep templates are being flagged by this so we need to ignore this rule.Issue #372
Expected behavior
TA-000013 should not detect Azure Functions as missing an identity when both SystemAssigned and UserAssigned are defined:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines