Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn monitoring on in the test code. #201

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Turn monitoring on in the test code. #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/fixture/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ module "aks" {
enable_http_application_routing = true
enable_azure_policy = true
enable_host_encryption = true
enable_log_analytics_workspace = true
sku_tier = "Paid"
private_cluster_enabled = true
enable_auto_scaling = true
Expand Down Expand Up @@ -77,6 +78,7 @@ module "aks_without_monitor" {
source = "../.."
prefix = "prefix2-${random_id.prefix.hex}"
resource_group_name = azurerm_resource_group.main.name
#checkov:skip=CKV_AZURE_4:The logging is turn off for demo purpose. DO NOT DO THIS IN PRODUCTION ENVIRONMENT!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this comment is used to disable a warning for www.checkov.io,
I dont know how to check if this comment is working as expected.

I understand CKV_AZURE_4 is correct and it means: Ensure Azure AKS cluster monitoring is enabled

https://docs.bridgecrew.io/docs/bc_azr_kubernetes_1

LGTM.

enable_log_analytics_workspace = false
net_profile_pod_cidr = "10.1.0.0/16"
depends_on = [azurerm_resource_group.main]
Expand Down