Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example path in readme file. #249

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Fix example path in readme file. #249

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fca418
Fix example path in readme file.
lonegunmanb Sep 14, 2022
b80cbf0
update readme as code review suggested
lonegunmanb Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ provider "kubernetes" {
}
```

To try the module, please run `terraform apply` command in `test/fixture` folder.
To try the module, please run `terraform apply` command in `examples`'s sub folder.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase this way:

Some examples to try the module, are available in the examples folder. These examples are tested against every PR with the E2E test.


## Pre-Commit & Pr-Check & Test

Expand Down Expand Up @@ -202,7 +202,7 @@ docker run --rm -v $(pwd):/src -w /src -e TF_VAR_key_vault_firewall_bypass_ip_ci
```

On Windows Powershell:

``
lonegunmanb marked this conversation as resolved.
Show resolved Hide resolved
```text
docker run --rm -v ${pwd}:/src -w /src -e TF_VAR_key_vault_firewall_bypass_ip_cidr="<your_cidr>" -e ARM_SUBSCRIPTION_ID -e ARM_TENANT_ID -e ARM_CLIENT_ID -e ARM_CLIENT_SECRET mcr.microsoft.com/azterraform:latest make e2e-test
```
Expand Down