Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow subnets without nsg on Firewall, Bastion and Gateway #132

Closed
wants to merge 1 commit into from
Closed

allow subnets without nsg on Firewall, Bastion and Gateway #132

wants to merge 1 commit into from

Conversation

withstu
Copy link
Contributor

@withstu withstu commented Jul 15, 2021

Exclude subnets that do not allow NSGs to be attatched to. Including Firewall, Bastion and Gateway.

solves #38

@ghost
Copy link

ghost commented Jul 15, 2021

CLA assistant check
All CLA requirements met.

@jtracey93
Copy link
Collaborator

Thanks @withstu I have actually updated this in the ESLZ repo where we take the policies from for the Terraform module.

@krowlandson when are we next planning a policy pull?

@krowlandson
Copy link
Contributor

@jtracey93 we can run a policy update and release a new patch version at any point for updates like this. Let's catch up tomorrow to see how quick we can push this out. Assume your update in ES covers all of the above?

@krowlandson krowlandson self-assigned this Jul 15, 2021
@krowlandson krowlandson self-requested a review July 15, 2021 21:04
@krowlandson
Copy link
Contributor

Also, just to say thank you @withstu for your contribution. Even if we don't merge this PR, we will use this to trigger an update from upstream which is due anyway :)

@krowlandson
Copy link
Contributor

@withstu, I believe this should now be covered by the new excludedSubnets parameter added to this policy in the latest release v0.4.0 so I will close this PR.

Please check out the upgrade notes as this update includes some significant changes.

If you have any further questions, please reach out and we'll be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants