-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Library Templates (automated) #221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krowlandson
added
bug
Something isn't working
enhancement
New feature or request
labels
Nov 25, 2021
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
matt-FFFFFF
approved these changes
Nov 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krowlandson Looks great - good work!
Please can we include the following in the release notes:
- Removal of policy defs - if customer wants to keep then they should make a copy and move to ./lib
- Loss of policy compliance history for all re-created assignments. Mention we are working to reduce the occurance of these in the future
- Obviously the changes needed to
configure_management_resources
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated 'pull_request' containing updates to the library templates stored in 'modules/archetypes/lib'.
Please review the 'files changed' tab to review changes.
Fixes #131
Fixes #190