Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Library Templates (automated) #221

Merged
merged 10 commits into from
Nov 26, 2021
Merged

Update Library Templates (automated) #221

merged 10 commits into from
Nov 26, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 25, 2021

This is an automated 'pull_request' containing updates to the library templates stored in 'modules/archetypes/lib'.
Please review the 'files changed' tab to review changes.

Fixes #131
Fixes #190

@krowlandson krowlandson self-assigned this Nov 25, 2021
@krowlandson krowlandson added bug Something isn't working enhancement New feature or request labels Nov 25, 2021
@krowlandson krowlandson added this to the v1.0.1 release milestone Nov 25, 2021
@krowlandson
Copy link
Contributor

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson marked this pull request as ready for review November 25, 2021 16:29
@krowlandson
Copy link
Contributor

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson linked an issue Nov 25, 2021 that may be closed by this pull request
@krowlandson
Copy link
Contributor

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krowlandson Looks great - good work!

Please can we include the following in the release notes:

  1. Removal of policy defs - if customer wants to keep then they should make a copy and move to ./lib
  2. Loss of policy compliance history for all re-created assignments. Mention we are working to reduce the occurance of these in the future
  3. Obviously the changes needed to configure_management_resources

:shipit: 👍

@krowlandson krowlandson merged commit c1726fe into main Nov 26, 2021
@krowlandson krowlandson deleted the patch-library branch November 26, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants