-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage checks and reports #62
Conversation
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage ? 63.37%
=======================================
Files ? 23
Lines ? 1977
Branches ? 72
=======================================
Hits ? 1253
Misses ? 724
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
💡🙏 Thank you so much for this, Here is my 2 cents: please note some key points if we plan to make this Like:
Reference to the codecov for this work |
src/tests/TestsRunHost.ts
Outdated
@@ -3,23 +3,26 @@ | |||
// ---------------------------------------------------------------------------- | |||
'use strict'; | |||
|
|||
import { | |||
runTests | |||
} from '@vscode/test-electron'; | |||
import * as path from 'path'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Just as a note: I see this kind of really solves the mystery for me, essentially all these tests already existed, and upon adding the test runner and coverage we get 63% coverage for free, which is a win! 🐴🚀🔔
@Tatsinnit thanks for your thoughts. My thought was to add this code cov at least not to reduce the existing 63% for future upcoming PR's and add a work item to increase the coverage for existing unit tests and for files which are missing unit test cases. I agree lot of this was well developed and matured but there is also lot of code which is legacy and some parts of it is not used. we can use this opportunity to refactor them and remove unused/dead code, also learn more in depth about this vscode extension. Please let me know your thoughts further on this and also how other extensions are achieving the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see you were able to use the codecov here as well!
This PR is for generating code coverage reports via c8 library and uploading them via codecov github action here
Sample Code Cove report
https://app.codecov.io/github/hsubramanianaks/vscode-bridge-to-kubernetes/commit/32888d1f7e1a2ef1ff5f3e5ddbd93c242092e6b9/tree/src/clients
Also PR comment will be generated by codecov stating Code Coverage reports here