Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the telemetry extension #64

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

Vidya2606
Copy link
Contributor

This PR is related to work item https://msazure.visualstudio.com/CloudNativeCompute/_workitems/edit/24534129

The package vscode-telementry-extension is deprecated, renaming it and updating the version.
https://www.npmjs.com/package/vscode-extension-telemetry?activeTab=versions

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #64 (cd217e9) into main (5fd56ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   66.93%   66.93%           
=======================================
  Files          33       33           
  Lines        2752     2752           
  Branches      105      105           
=======================================
  Hits         1842     1842           
  Misses        909      909           
  Partials        1        1           
Flag Coverage Δ
unittests 66.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 Looks good to me, I hope we have tested this, and I think we are not dropping a lot of telemetry from this PR?

Thank you!

package.json Show resolved Hide resolved
@Tatsinnit Tatsinnit added the enhancement 🧑‍🔧💡 New feature or request label Oct 26, 2023
@Vidya2606 Vidya2606 merged commit b932836 into Azure:main Nov 2, 2023
4 checks passed
@Vidya2606 Vidya2606 deleted the vidyareddyReplace-old-telemetry branch November 2, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🧑‍🔧💡 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants