change to service.name to show correct ingress url's #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 65.33% 66.93% +1.59%
==========================================
Files 33 33
Lines 2634 2752 +118
Branches 101 105 +4
==========================================
+ Hits 1721 1842 +121
+ Misses 913 909 -4
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tatsinnit
approved these changes
Sep 11, 2023
Vidya2606
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to fix the issue of not showing ingress url's in kubernetes status bar due to issue of using deprecated property names. ingress.items.spec.rules.http.paths.backend.serviceName was changed to ingress.items.spec.rules.http.paths.backend.service.name as part of this PR here. More details here.
After this PR : (note displays the ingress url's) before it wasn't displaying unless if cluster ingress was v1beta which is deprecated now.