-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the unused telemetry events #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 73.67% 73.57% -0.11%
==========================================
Files 37 37
Lines 3199 3130 -69
Branches 149 149
==========================================
- Hits 2357 2303 -54
+ Misses 837 822 -15
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closed
hsubramanianaks
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the last step in reclassification of Telemetry events.
After migrating from deprecated npm dependency "vscode-extension-telemetry" to new dependency "@vscode/extension-telemetry" the Extension Name changed from "mindaro" to "mindaro.mindaro", I classified only the events which are required (these events will be saved in the main table RawEventsVSCodeExt) and left the unwanted events as is (these events will be stored in unclassified table RawEventsVSCodeExtUnclassified)
This work was done and was released successfully in the Nov release. And made sure all the classified events are being logged in the appropriate table.
Now as the final step I'm cleaning the code so that the logs will not be logged under unclassified table which is waste of data/not required data.
Here is the consolidated list of events.
https://msazure.visualstudio.com/CloudNativeCompute/_wiki/wikis/personalplayground/594061/Deprecation-of-npm-dependency-vscode-extension-telemetry%E2%80%8B%E2%80%8B%E2%80%8B-