Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the unused telemetry events #83

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

Vidya2606
Copy link
Contributor

@Vidya2606 Vidya2606 commented Dec 9, 2023

This PR is the last step in reclassification of Telemetry events.

After migrating from deprecated npm dependency "vscode-extension-telemetry"​​​ to new dependency "@vscode/extension-telemetry" the Extension Name changed from "mindaro" to "mindaro.mindaro", I classified only the events which are required (these events will be saved in the main table RawEventsVSCodeExt) and left the unwanted events as is (these events will be stored in unclassified table RawEventsVSCodeExtUnclassified)
This work was done and was released successfully in the Nov release. And made sure all the classified events are being logged in the appropriate table.
Now as the final step I'm cleaning the code so that the logs will not be logged under unclassified table which is waste of data/not required data.

Here is the consolidated list of events.
https://msazure.visualstudio.com/CloudNativeCompute/_wiki/wikis/personalplayground/594061/Deprecation-of-npm-dependency-vscode-extension-telemetry%E2%80%8B%E2%80%8B%E2%80%8B-

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20bdf28) 73.67% compared to head (be8bbb2) 73.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   73.67%   73.57%   -0.11%     
==========================================
  Files          37       37              
  Lines        3199     3130      -69     
  Branches      149      149              
==========================================
- Hits         2357     2303      -54     
+ Misses        837      822      -15     
  Partials        5        5              
Flag Coverage Δ
unittests 73.57% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
@Vidya2606 Vidya2606 merged commit 77455ca into Azure:main Jan 11, 2024
4 checks passed
@Vidya2606 Vidya2606 deleted the removeUnusedTelemetryEvents branch January 11, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants