Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NameNotFoundException: com.android.chrome #1334

Closed
1 of 7 tasks
Skirtek opened this issue Aug 10, 2019 · 1 comment
Closed
1 of 7 tasks

[Bug] NameNotFoundException: com.android.chrome #1334

Skirtek opened this issue Aug 10, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@Skirtek
Copy link

Skirtek commented Aug 10, 2019

Which Version of MSAL are you using ?
MSAL v4.0.0

Platform
Xamarin Forms 4.1

What authentication flow has the issue?

  • Desktop / Mobile
    • Interactive
    • Integrated Windows Auth
    • Username Password
    • Device code flow (browserless)
  • Web App
    • Authorization code
    • OBO
  • Web API
    • OBO

Is this a new or existing app?
The app is in production, and I have not upgraded to a new version of MSAL

Repro

  1. Uninstall Chrome from rooted device
  2. Try to log in/register in mobile app which is using MSAL library

Expected behavior
Method IsChromeEnabled should not throw exception and return false which should force open system browser.

Actual behavior
When user hasn't Chrome on his phone PackageManager throws NameNotFoundException: com.android.chrome. I can't uninstall Chrome on any device, so I'm a little bit scared that this user can not log in into application.

Possible Solution
Method IsChromeEnabled in AndroidPlatformProxy should catch exception and return false

@bgavrilMS bgavrilMS added the bug label Aug 12, 2019
@bgavrilMS bgavrilMS added this to the 4.3.1 milestone Aug 12, 2019
@bgavrilMS bgavrilMS self-assigned this Aug 12, 2019
@bgavrilMS
Copy link
Member

Are you sure it's the Username / Password flow that you're using here? I'm pretty sure we don't call IsChromeEnabled except on Interactive flow. Username / Password is when your app collects the credentails on its own and passes them to MSAL (we discourage this for security reasons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants