Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M] CCA cache - Log error when cache is not serialized #2461

Closed
pmaytak opened this issue Mar 9, 2021 · 7 comments
Closed

[M] CCA cache - Log error when cache is not serialized #2461

pmaytak opened this issue Mar 9, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@pmaytak
Copy link
Contributor

pmaytak commented Mar 9, 2021

For confidential client apps, log error when cache is not serialized.

@pmaytak pmaytak self-assigned this Mar 9, 2021
@pmaytak pmaytak added this to the 4.28.0 milestone Mar 9, 2021
@jmprieur
Copy link
Contributor

jmprieur commented Mar 9, 2021

@pmaytak, ,

  • we should log an error (but not throw)
  • the error message should be: The default token cache provided by MSAL is not designed to be performant when used in confidential client applications. Please use token cache serialization. See https://aka.ms/msal-net-cca-token-cache-serialization.

@BobBonser
Copy link

I am getting this error in my log even though I do have AddInMemoryCaches in my startup

        var initialScopes = Configuration.GetValue<string>("DownstreamApi:Scopes")?.Split(' ');

        services.AddMicrosoftIdentityWebAppAuthentication(Configuration, "AzureAd")
            .EnableTokenAcquisitionToCallDownstreamApi(initialScopes)
                .AddMicrosoftGraph(Configuration.GetSection("DownstreamApi"))
                .AddInMemoryTokenCaches();

@pmaytak
Copy link
Contributor Author

pmaytak commented Nov 5, 2021

Thanks @BobBonser, Is this the same issue as #2990?

@jmprieur
Copy link
Contributor

jmprieur commented Nov 6, 2021

Which version of Id.Web do you use. @BobBonser ?

@BobBonser
Copy link

BobBonser commented Nov 6, 2021 via email

@BobBonser
Copy link

BobBonser commented Nov 6, 2021 via email

@bgavrilMS
Copy link
Member

@BobBonser - Microsoft.Identity.Web ... But let's continue the conversation of #2990, as this issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants