Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Regional - if regional is configured, and original authority is known to MSAL, do not perform instance discovery #2777

Closed
bgavrilMS opened this issue Jul 16, 2021 · 1 comment · Fixed by #2789
Closed

[Bug] Regional - if regional is configured, and original authority is known to MSAL, do not perform instance discovery #2777

bgavrilMS opened this issue Jul 16, 2021 · 1 comment · Fixed by #2789
Assignees
@bgavrilMS
Labels
bug
Milestone
4.35.0

Comments

@bgavrilMS
Copy link
Member

msal 4.34

  1. Configure .WithAzureRegion("westus1")
  2. Configure a well known authority like "login.microsotonline.com"

Expected:

  • no instance discovery should be performed
  • we're ok to live with potential SSO islands. It's better than global traffic.

Actual:

  • instance discovery on the non-regional environment
@bgavrilMS bgavrilMS added this to the 4.35.0 milestone Jul 20, 2021
@bgavrilMS bgavrilMS self-assigned this Jul 21, 2021
@bgavrilMS
Copy link
Member Author

Looks like this isn't actually an issue. If the authority is known to MSAL, then we don't do validation.

bgavrilMS added a commit that referenced this issue Jul 21, 2021
@bgavrilMS
Regional fixes #2777 #22778 - use preferred_network & don't do author…
057e10d 
…ity validation of known cloud
@bgavrilMS bgavrilMS mentioned this issue Jul 21, 2021
Merged
pmaytak added a commit that referenced this issue Jul 21, 2021
@bgavrilMS @pmaytak
Use preferred_network and skip discovery for known clouds (#2789)
8362724 
* Regional fixes #2777 #22778 - use preferred_network & don't do authority validation of known cloud

* Fix some tests

* fix

* Fix for region being prepended to regionalized host (reverted back code) and add a unit test. Addressed minor PR feedback.

Co-authored-by: pmaytak <34331512+pmaytak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgavrilMS bgavrilMS

Labels
bug
Projects
None yet
Milestone
4.35.0
2 participants
@bgavrilMS @pmaytak