Add more logging and small enhacement to an int test #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //await RunOnBehalfOfTestAsync(aadUser2, false).ConfigureAwait(false); | ||
| //await RunOnBehalfOfTestAsync(adfsUser, true).ConfigureAwait(false); | ||
| //await RunOnBehalfOfTestAsync(aadUser2, true).ConfigureAwait(false); | ||
| //await RunOnBehalfOfTestAsync(aadUser2, false, true).ConfigureAwait(false); |
There was a problem hiding this comment.
Any reason for commenting these?
pmaytak
reviewed
Jun 4, 2021
| private void LogReturnedToken(AuthenticationResult result) | ||
| { | ||
| if (result.AccessToken != null && | ||
| AuthenticationRequestParameters.RequestContext.Logger.IsLoggingEnabled(LogLevel.Info)) | ||
| { | ||
| int appHashCode = AuthenticationRequestParameters.AppConfig.GetHashCode(); |
There was a problem hiding this comment.
- Maybe rename here and in log below to appConfigHashCode?
- In which scenario would this hash code be useful?
There was a problem hiding this comment.
I think the hash code is useful to know the instance of confidential client being used to track how many CCA are created.
There was a problem hiding this comment.
Yes, just as Neha stated, it's used to differentiate between different CCA objects. It's to be able to tell if ppl are using 1 or more instances of CCA object, as it has cache implications.
trwalke
approved these changes
Jun 4, 2021
pmaytak
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - no work item, need more logging for investigation.
Changes proposed in this request
Testing
Performance impact