Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix 4.36.2 #2913

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Hot fix 4.36.2 #2913

merged 3 commits into from
Sep 29, 2021

Conversation

SameerK-MSFT
Copy link
Contributor

@SameerK-MSFT SameerK-MSFT commented Sep 29, 2021

Fixes #2897.
Issue about broker failure in iOS

Seems like original issue was deleted.

MSAL 4.36.1
When customer called PCA.GetAccountsAsync() on iOS with broker, it throws exception with message
UIViewController is null, so MSAL.NET cannot invoke the iOS broker. See https://aka.ms/msal-net-ios-broker .
Stack

at Microsoft.Identity.Client.Platforms.iOS.iOSBroker.IsBrokerInstalledAndInvokable () [0x00057] in <7cee57cda5c7458490ed414ae408d3f6>:0 at Microsoft.Identity.Client.ClientApplicationBase.GetAccountsFromBrokerAsync (System.String homeAccountIdFilter, Microsoft.Identity.Client.Cache.ICacheSessionManager cacheSessionManager, System.Threading.CancellationToken cancellationToken) [0x00064] in <7cee57cda5c7458490ed414ae408d3f6>:0 at Microsoft.Identity.Client.ClientApplicationBase.GetAccountsInternalAsync (Microsoft.Identity.Client.TelemetryCore.Internal.Events.ApiEvent+ApiIds apiId, System.String homeAccountIdFilter, System.Threading.CancellationToken cancellationToken) [0x0022c] in <7cee57cda5c7458490ed414ae408d3f6>:0 at Microsoft.Identity.Client.ClientApplicationBase.GetAccountsAsync (System.Threading.CancellationToken cancellationToken) [0x00078] in <7cee57cda5c7458490ed414ae408d3f6>:0 at Microsoft.Identity.Client.ClientApplicationBase.GetAccountsAsync () [0x00076] in <7cee57cda5c7458490ed414ae408d3f6>:0 at UserDetailsClient.MainPage.AcquireTokenAsync () [0x0007f] in /Users/samkhand/Desktop/Gits/ReleaseTest/active-directory-xamarin-native-v2/2-With-broker/UserDetailsClient/UserDetailsClient/MainPage.xaml.cs:114

Changes proposed in this request
Merging hotfix back in the master
Changes include adding a check if broker is installed

Testing
As per the Hotfix branch

Performance impact
NA

SameerK-MSFT and others added 3 commits September 27, 2021 08:31
* Added back CanBrokerSupportSilentAuth

* The method is not needed on Android

* Couple of missed retro

* iOSBroker installed returns true
* Remove iOS and Android UI automation tests
* Re-add AppCenter tests
@bgavrilMS bgavrilMS merged commit 2b1c872 into master Sep 29, 2021
@bgavrilMS bgavrilMS deleted the HotFix_4.36.2 branch September 29, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Broker Authentication in 4.36.1 is broken?
4 participants