Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable runtime logging from new preview broker #3875

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Disable runtime logging from new preview broker #3875

merged 3 commits into from
Dec 19, 2022

Conversation

gladjohn
Copy link
Contributor

@gladjohn gladjohn commented Dec 19, 2022 •
edited
Loading

Fixes #

Changes proposed in this request

  • disabling runtime logger by not passing the log callback delegate from broker
  • Verified that logger is not initialized after removing the code using the Dev App (NetDesktopWinFormsWAM)
  • Minimal amount of code removal so it will be easier to plugin the feature for the next release
  • updated the failing tests (WamUsernamePasswordRequestWithPOPAsync/WamUsernamePasswordRequestAsync) by commenting it.

Testing
NetDesktopWinFormsWAM Dev App

Performance impact
should improve perf for new broker as we are not logging broker messages anymore

Documentation

  • All relevant documentation is updated.

pmaytak
pmaytak approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests will have to be updated too.

@gladjohn gladjohn merged commit fbb21fa into main Dec 19, 2022
@gladjohn gladjohn deleted the gladjohn/disable_runtime_logging branch December 19, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmaytak pmaytak pmaytak approved these changes

@neha-bhargava neha-bhargava neha-bhargava approved these changes

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gladjohn @pmaytak @neha-bhargava @GladwinJohnson