Upgrade linter and address new warnings #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
chlowell
commented
Aug 11, 2022
| @@ -84,7 +85,7 @@ func New(reqState string, port int) (*Server, error) { | |||
|
|
|||
| serv := &Server{ | |||
| Addr: fmt.Sprintf("http://localhost:%s", portStr), | |||
| s: &http.Server{Addr: "localhost:0"}, | |||
| s: &http.Server{Addr: "localhost:0", ReadHeaderTimeout: time.Second}, | |||
There was a problem hiding this comment.
This is the Slowloris fix. We could simply disable the check because there's no vulnerability here--this is the only server in MSAL and it runs on localhost. If users want to Slowloris the local server trying to help them authenticate, that's okay. But the header timeout won't hurt anything and it feels cleaner to me than disabling a warning 🤷
jhendrixMSFT
approved these changes
Aug 11, 2022
keegan-caruso
approved these changes
Aug 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.