Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithLoginHint option for interactive authentication #354

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Add WithLoginHint option for interactive authentication #354

merged 2 commits into from
Oct 25, 2022

Conversation

chlowell
Copy link
Collaborator

@chlowell chlowell commented Oct 11, 2022 •
edited
Loading

Closes #271 by adding an option to set login_hint for interactive auth and auth code URLs. Usage looks like this:

token, err := client.AcquireTokenInteractive(context.Background(), scopes, public.WithLoginHint("upn")

@chlowell chlowell added the enhancement New feature or request label Oct 11, 2022
bgavrilMS
bgavrilMS approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chlowell chlowell merged commit e0d0f06 into dev Oct 25, 2022
@chlowell chlowell deleted the chlowell/login-hint branch October 25, 2022 00:15
@rayluo rayluo mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@keegan-caruso keegan-caruso keegan-caruso approved these changes

@rayluo rayluo Awaiting requested review from rayluo

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support login_hint in auth code flow
3 participants
@chlowell @bgavrilMS @keegan-caruso