Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging audit and logging docs #382

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Logging audit and logging docs #382

merged 2 commits into from
Feb 16, 2023

Conversation

bgavrilMS
Copy link
Member

Fix for #28

  1. Review all logs to ensure there is no PII (the library would need to expose a PII flag to be able to log PII)
  2. Provide some clarity in the docs about what PII is and what the library logs.

chlowell
chlowell approved these changes Feb 13, 2023
View reviewed changes
apps/design/design.md Outdated Show resolved Hide resolved
@bgavrilMS @chlowell
Update apps/design/design.md
02c91b6 
Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bgavrilMS bgavrilMS merged commit 048f40f into dev Feb 16, 2023
@bgavrilMS bgavrilMS deleted the bogavril/logging branch February 16, 2023 13:51
@chlowell chlowell mentioned this pull request Mar 1, 2023
Closed
@rayluo rayluo mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@rayluo rayluo Awaiting requested review from rayluo

@element-of-surprise element-of-surprise Awaiting requested review from element-of-surprise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgavrilMS @chlowell