Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename public client CreateAuthCodeURL -> AuthCodeURL #384

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

chlowell
Copy link
Collaborator

@chlowell chlowell commented Feb 13, 2023

Closes #371, part of #380. Confidential client has AuthCodeURL, public client has CreateAuthCodeURL. Either name is okay but there should only be one. I chose AuthCodeURL because it doesn't imply creating a server-side resource and is shorter.

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chlowell chlowell merged commit 0af1c20 into dev Feb 15, 2023
@chlowell chlowell deleted the chlowell/authcode branch February 15, 2023 21:53
@rayluo rayluo mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] CreateAuthCodeURL Naming Consistency
2 participants