Rename confidential.WithAccessor to WithCache #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Feb 14, 2023
chlowell
force-pushed
the
chlowell/WithCache
branch
from
c666222
to
b5532eb
Compare
|
SonarCloud Quality Gate failed.
|
|
SonarCloud is red because aligning the option name and documentation for both clients created too much duplication in this PR. I merged anyway because that duplication is by design and not a quality problem. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #380. Confidential client has
WithAccessor, public client hasWithCache, but both should have the same name because they do same thing.WithCachelooks better to me because it indicates more clearly what the option does.