Replace NewCredFromCert with NewCredFromCertChain #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
bgavrilMS
approved these changes
Feb 23, 2023
bgavrilMS
approved these changes
Feb 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #380. We added
NewCredFromCertChainto fully support SNI auth. It has an awkward name and makes the single cert constructorNewCredFromCertredundant.NewCredFromCertChainis also more ergonomic because it pairs better with the cert loading helper and can return an error (bad input toNewCredFromCertisn't reported until authentication fails). So, deleting the worse constructor and giving the good name to the better constructor makes the API better overall.