Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NewCredFromCert with NewCredFromCertChain #391

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

chlowell
Copy link
Collaborator

Part of #380. We added NewCredFromCertChain to fully support SNI auth. It has an awkward name and makes the single cert constructor NewCredFromCert redundant. NewCredFromCertChain is also more ergonomic because it pairs better with the cert loading helper and can return an error (bad input to NewCredFromCert isn't reported until authentication fails). So, deleting the worse constructor and giving the good name to the better constructor makes the API better overall.

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chlowell chlowell merged commit 7d2056c into dev Feb 23, 2023
@chlowell chlowell deleted the chlowell/cred-from-cert branch February 23, 2023 21:06
@rayluo rayluo mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants