Upgrade CI tools

[chlowell]

Upgrading CI to use the latest version of Go and linter. The upgraded linter flagged a method call that has no side effect and whose return value is discarded i.e., the call has no effect. I deleted this call because it's unnecessary in any case--there's no reason to update DeviceCodeResult.ExpiresOn because it's the moment at which the code expires, not the amount of time remaining until the code expires.

[rayluo]

a method call that has no side effect and whose return value is discarded i.e., the call has no effect. I deleted this call because it's unnecessary in any case--there's no reason to update DeviceCodeResult.ExpiresOn because it's the moment at which the code expires, not the amount of time remaining until the code expires.

Makes sense. Agree with its removal. FWIW, that line was introduced in a 5000-line change PR. Perhaps it was meant to be a hack to simulate the expiration for testing.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information