Adding some better diagnostics for len(scopes) == 0 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
chlowell
approved these changes
Apr 12, 2023
Comment on lines
+340
to
+346
| // TODO(someone): we could look deeper at the message to determine if | ||
| // it's a scope error, but this is a good start. | ||
| /* | ||
| {error":"invalid_scope","error_description":"AADSTS1002012: The provided value for scope | ||
| openid offline_access profile is not valid. Client credential flows must have a scope value | ||
| with /.default suffixed to the resource identifier (application ID URI)...} | ||
| */ |
There was a problem hiding this comment.
Suggested change
| // TODO(someone): we could look deeper at the message to determine if | |
| // it's a scope error, but this is a good start. | |
| /* | |
| {error":"invalid_scope","error_description":"AADSTS1002012: The provided value for scope | |
| openid offline_access profile is not valid. Client credential flows must have a scope value | |
| with /.default suffixed to the resource identifier (application ID URI)...} | |
| */ |
| with /.default suffixed to the resource identifier (application ID URI)...} | ||
| */ | ||
| if len(a.Scopes) == 0 { | ||
| return fmt.Errorf("token request had an empty authority.AuthParams.Scopes, which is invalid") |
There was a problem hiding this comment.
AuthParams is internal, the public API is a scopes []string parameter
Suggested change
| return fmt.Errorf("token request had an empty authority.AuthParams.Scopes, which is invalid") | |
| return fmt.Errorf("a token request requires at least one scope") |
chlowell
added a commit
that referenced
this pull request
Apr 13, 2023
Merged
chlowell
added a commit
that referenced
this pull request
Apr 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue:
#304