Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize cache keys #425

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Normalize cache keys #425

merged 1 commit into from
Jun 16, 2023

Conversation

chlowell
Copy link
Collaborator

...according to the schema. This is a compatible change because MSAL Go uses these keys only when writing the cache. (Cache data is stored in maps but when searching, we iterate these rather than index them (for example)).

Closes #367

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chlowell chlowell added the bug Something isn't working label Jun 15, 2023
@chlowell chlowell marked this pull request as ready for review June 15, 2023 22:14
@chlowell chlowell merged commit 5d7178b into dev Jun 16, 2023
7 checks passed
@chlowell chlowell deleted the chlowell/cache-keys branch June 16, 2023 18:24
bgavrilMS pushed a commit that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure cache interoperability with other MSALs
3 participants