Public client silent auth requires an account #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
bgavrilMS
approved these changes
Jun 28, 2023
jhendrixMSFT
approved these changes
Jun 29, 2023
rayluo
approved these changes
Jun 30, 2023
bgavrilMS
pushed a commit
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silent auth already fails for most public clients when the caller doesn't specify an account, because in that case the client searches the cache for a token having home account ID
""and all user tokens have a nonempty value. However, if a public client shares its cache with a confidential client, it can return the application's token in this case--see #419 (comment) for details. It's unlikely any developer would create that scenario, however it's worth preventing because it can lead to authenticating an unexpected identity, which is dangerous and hard to debug.